Skip to content

Fixed bug where feedForwardActiveColumns was getting overwritten #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2016
Merged

Fixed bug where feedForwardActiveColumns was getting overwritten #437

merged 1 commit into from
Jul 21, 2016
+495 −3

Conversation

cogmission
Copy link
Collaborator

Fixes #436

feedForwardActiveColumns is now set from a fresh int[] and not reusing the pointer to the stale field.

Also adding the NetworkConsistencyTest class to test all outputs are isolated.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 81.136% when pulling 557d090 on cogmission:ActiveColumnsOverwriteFix into 1d58c62 on numenta:master.

@cogmission
Copy link
Collaborator Author

@rhyolight If you could do the honors! This might be the NAB problem! ;-)

@rhyolight rhyolight merged commit e3c50a2 into numenta:master Jul 21, 2016
@cogmission cogmission deleted the ActiveColumnsOverwriteFix branch July 23, 2016 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cogmission @coveralls @rhyolight