Refactored CMakeLists.txt to use nupic.core as an external library #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Only outstanding issue seems to be that python 2.7 is being used in the 2.6 builds, but that is consistent w/ current master (see #1520). Would like to know the opinions of @scottpurdy and @rhyolight regarding how to move forward. Otherwise, this is ready for consideration. |
Member
|
I'd say this depends on #1520 for a merge (unless we want to consider dropping 2.6 support again?) |
Contributor
Author
|
I'm going to chew on it for a bit. We've fixed it before, so we should be able to do it again, but I'm becoming less and less interested in officially supporting 2.6 as time passes. |
Member
Me too. |
oxtopus
force-pushed
the
cmake-cleanup
branch
3 times, most recently
from
05af600 to
66063eb
Compare
…d not require direct access to the source repository
Conflicts: .nupic_modules
Conflicts: .nupic_modules
…ing version being found
… as use correct WORKDIR value
oxtopus
force-pushed
the
cmake-cleanup
branch
from
fc3d450 to
fe5dc1a
Compare
oxtopus
added a commit
that referenced
this pull request
Nov 18, 2014
Refactored CMakeLists.txt to use nupic.core as an external library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuPIC complement to numenta/nupic.core-legacy#228
This is an API-breaking change to nupic with a refactored CMakeLists.txt to need only access to a nupic.core installation prefix which is specified via -DNUPIC_CORE cmake option (as before), but no longer requires access to the raw source code repository. Howeverm if -DNUPIC_CORE_SOURCE is specified, that overrides the value in .nupic_modules for repository location should nupic.core need to be build inside the nupic source tree.
Note: I'd like to be able to re-write the history in this one to exclude mention of my own fork in .nupic_modules. Once ffd7b57110e016e31fbe959dc5fcab74dd86960b is resolvable from git://github.com/numenta/nupic.core.git I will make that change and redo this PR.