FEAT: logaddexp ufunc implementation
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juntyr
approved these changes
Oct 15, 2025
Yeah sure, With the help of some past work at NumPy, no we can happily move to implementing all the available ufuncs |
|
Cool let's take this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds support for the
logaddexpfunction (log(exp(x) + exp(y))) for quad-precision and long double types, including a numerically stable implementation and comprehensive tests. It also updates documentation to reflect this new support.New
logaddexpimplementation and registrationlogaddexpfor both quad-precision (Sleef_quad) and long double types, handling edge cases such as NaN and infinities. (quaddtype/numpy_quaddtype/src/ops.hpp[1] [2]logaddexpoperation as a universal function (ufunc) so it is available in the NumPy extension. (quaddtype/numpy_quaddtype/src/umath/binary_ops.cppquaddtype/numpy_quaddtype/src/umath/binary_ops.cppR243-R245)Testing enhancements
logaddexp, covering a wide range of values (regular, large, small, and special cases like inf/nan), and verifying mathematical properties and edge cases. (quaddtype/tests/test_quaddtype.pyquaddtype/tests/test_quaddtype.pyR431-R530)quaddtype/tests/test_quaddtype.py[1] [2]Documentation
logaddexpis now implemented and tested for both quad and long double types. (quaddtype/release_tracker.mdquaddtype/release_tracker.mdL13-R13)