FEAT: modf ufunc implementation
#192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juntyr
approved these changes
Oct 22, 2025
| # Numbers close to integers | ||
| "0.999999999999", "-0.999999999999", "1.000000000001", "-1.000000000001", | ||
| # Special values | ||
| "inf", "-inf", "nan", |
There was a problem hiding this comment.
Can we also test -0.0 and +0.0?
There was a problem hiding this comment.
They are on the line 2468
|
Cool lets merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request adds full support for the
modffunction for the QuadPrecision dtype, including its implementation, integration with NumPy ufuncs, and comprehensive tests to ensure correct behavior. The changes cover both the backend C++ implementation and Python-level testing, and update the release tracker to reflect the new support.Implementation of
modffor QuadPrecisionmodfand similar) inops.hpp, including bothSleef_quadandlong doublebackends. [1] [2]NumPy Ufunc Integration
modfufunc for QuadPrecision inunary_ops.cpp. [1] [2]Testing and Documentation
np.modfwith QuadPrecision, checking a wide range of inputs and validating consistency with NumPy's float64 behavior.modfis now fully supported for QuadPrecision.