BUG: Fix Round-tripping QuadPrecision through string #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #196
Cause:
For conversion from quad -> string, earlier we were using the strict 33 as significant decimal digit precision for dragon4 (which is the minimum value) so some random inputs were getting successfully round-trip but not all.
For example with original behaviour,
np.random.seed(0)should pass but notnp.random.seed(1)or others128-bit quad support 33-36 so we should be setting this value to the max, as for any irregular representation Quad(x) can give upto max 36 significant decimal digit precision but our conversion to string will only preserve 33.
source: https://en.wikipedia.org/wiki/Quadruple-precision_floating-point_format