Skip to content

Update params.images to fix Twitter Cards (and header meta data) #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

Update params.images to fix Twitter Cards (and header meta data) #357

merged 1 commit into from
Sep 1, 2020

Conversation

@joelachance
Copy link
Contributor

@joelachance joelachance commented Aug 31, 2020

Fixes missing images when using Twitter cards (I hope)

@joelachance joelachance mentioned this pull request Aug 31, 2020
Merged
InessaPawson
InessaPawson approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try.

rgommers
rgommers approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe!

@rgommers rgommers merged commit a9e4afb into master Sep 1, 2020
@rgommers rgommers deleted the bug/twitter-cards branch September 1, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers approved these changes

@InessaPawson InessaPawson InessaPawson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelachance @rgommers @InessaPawson