Skip to content

Fix: unintended index out of range exception on other exception #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Fix: unintended index out of range exception on other exception #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
005ff07
Fix: unintended `index out of range exception` on other exception
Akeit0 Feb 13, 2025
b94c674
Fix: reset order
Akeit0 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Lua/Runtime/LuaVirtualMachine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,16 +932,17 @@ static bool MoveNext(ref VirtualMachineExecutionContext context, out PostOperati
}
catch (Exception e)
{
context.PopOnTopCallStackFrames();
context.State.CloseUpValues(context.Thread, context.FrameBase);
LuaValueArrayPool.Return1024(context.ResultsBuffer, true);
if (e is not LuaRuntimeException)
{
var newException = new LuaRuntimeException(GetTracebacks(ref context), e);
var newException = new LuaRuntimeException(context.State.GetTraceback(), e);
context.PopOnTopCallStackFrames();
Copy link

@CodeSmile-0000011110110111 CodeSmile-0000011110110111 Apr 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context is default, calling a method on it will throw a nullref
maybe you wanted to pop first, then assign default? That seems to work for me but no idea if that's correct.

Copy link
Collaborator Author

@Akeit0 Akeit0 Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen this commit?

Copy link
Collaborator Author

@Akeit0 Akeit0 Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full change can be seen at https://github.com/nuskey8/Lua-CSharp/pull/101/files.

context = default;
throw newException;
}

context.PopOnTopCallStackFrames();
throw;
}
}
Expand Down