Skip to content

fix(editor): create portal for monaco overflow widgets #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

fix(editor): create portal for monaco overflow widgets #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ccc465
fix(editor): create portal for monaco overflow widgets
farnabaz Nov 6, 2025
77c5c84
lint: fix
farnabaz Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/src/components/AppLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,14 @@ function onLeave(el: Element, done: () => void) {
>
<div
v-if="open"
class="fixed top-0 bottom-0 left-0 overflow-y-auto border-r border-default flex flex-col max-w-full bg-default"
class="fixed top-0 bottom-0 left-0 border-r border-default flex flex-col max-w-full bg-default"
:style="sidebarStyle"
>
<!-- This is needed for the Monaco editor to be able to position the portal correctly -->
<div class="monaco-editor">
<div id="monaco-portal" />
</div>

<AppHeader />

<div class="flex-1 overflow-y-auto relative">
Expand Down
7 changes: 7 additions & 0 deletions src/app/src/composables/useMonaco.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,19 @@ export function useMonaco(target: Ref<HTMLElement | undefined>, options: UseMona

const colorMode = unref(options.colorMode) || 'dark'

const monacoPortal = (el.getRootNode() as Document)?.getElementById('monaco-portal') || undefined
if (monacoPortal) {
monacoPortal.style.position = 'absolute'
monacoPortal.style.top = el.getClientRects()[0].top + 'px'
}

// Create editor instance (use the custom createEditor wrapper from setupMonaco)
editor.value = monaco.createEditor(el, {
theme: getTheme(colorMode),
lineNumbers: 'off',
readOnly: options.readOnly ?? false,
wordWrap: 'on',
overflowWidgetsDomNode: monacoPortal,
scrollbar: options.readOnly
? {
vertical: 'hidden',
Expand Down
Loading