fix(app): handle item prefix as string #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hendrikheil is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
hendrikheil
force-pushed
the
fix/app/item-card-form-prefix-validation
branch
from
464ca0a to
850cd7e
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
hendrikheil
force-pushed
the
fix/app/item-card-form-prefix-validation
branch
from
850cd7e to
78cef06
Compare
commit: |
hendrikheil
force-pushed
the
fix/app/item-card-form-prefix-validation
branch
from
78cef06 to
e6f5f76
Compare
hendrikheil
force-pushed
the
fix/app/item-card-form-prefix-validation
branch
from
a6293c8 to
62e0c73
Compare
hendrikheil
force-pushed
the
fix/app/item-card-form-prefix-validation
branch
from
62e0c73 to
33eafdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85 by changing prefix type from a number to a string.
The primary issue with treating the prefix as a number is that it leads to a loss of leading zeros.
Making the prefix a string also aligns more with how nuxt content handles this, which documents the ordering to be alphabetically, not numerically.