Skip to content

Conversation

danielroe
Copy link
Collaborator

No description provided.

@danielroe danielroe self-assigned this Aug 19, 2022
@dargmuesli
Copy link
Contributor

I get the following error message trying this branch on bridge:

 FATAL  Cannot find module '/..../node_modules/@nuxtjs/html-validator/dist/runtime/validator' imported from /..../node_modules/@nuxtjs/html-validator/dist/module.mjs

  at new NodeError (node:internal/errors:387:5)
  at finalizeResolution (node:internal/modules/esm/resolve:404:11)
  at moduleResolve (node:internal/modules/esm/resolve:965:10)
  at defaultResolve (node:internal/modules/esm/resolve:1173:11)
  at nextResolve (node:internal/modules/esm/loader:173:28)
  at ESMLoader.resolve (node:internal/modules/esm/loader:852:30)
  at ESMLoader.getModuleJob (node:internal/modules/esm/loader:439:18)
  at ESMLoader.import (node:internal/modules/esm/loader:536:22)
  at importModuleDynamically (node:internal/modules/esm/translators:110:35)
  at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14)

I have a validator.mjs in the mentioned runtime directory though.

@yoonpoon
Copy link

Hey @danielroeand @dargmuesli, will this PR support the failOnError option for Nuxt Bridge and Nuxt 3? Thanks!

@danielroe
Copy link
Collaborator Author

danielroe commented Sep 15, 2022

It does 😊

I only need to make a couple of tweaks and it's ready to go

@netlify
Copy link

netlify bot commented Sep 18, 2022

Deploy Preview for html-validator canceled.

Name Link
🔨 Latest commit c8bb858
🔍 Latest deploy log https://app.netlify.com/sites/html-validator/deploys/633054bebcbbec0008e4f779

@danielroe danielroe marked this pull request as ready for review September 24, 2022 10:31
@danielroe danielroe merged commit b134043 into main Sep 25, 2022
@danielroe danielroe deleted the feat/nuxt3 branch September 25, 2022 13:21
Copy link
Contributor

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 works for me. Thanks! I learned a lot with this migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants