-
Notifications
You must be signed in to change notification settings - Fork 99
perf(create-nuxt): refactor for improved tree-shaking #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundle Stats β nuxi size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller
Unchanged
|
Bundle Stats β create-nuxt size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats β nuxt-cli size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller
Unchanged
|
commit: |
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
=======================================
Coverage ? 27.03%
=======================================
Files ? 76
Lines ? 4002
Branches ? 214
=======================================
Hits ? 1082
Misses ? 2891
Partials ? 29 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1044 will not alter performanceComparing Summary
|
I'm really not sure if the benchmark CI failing is related to this PR. Could you please confirm @danielroe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh beautiful! thank you for tackling this one β€οΈ
π Linked issue
Resolves #927
β Type of change
π Description
This PR refactors
nuxi
to avoid including all possible commands in bundle, when possible. Mainly this was achieved by isolatingrunCommand
fromcommands
. This was especially important forcreate-nuxt
as it was only using themodule add
,init
, andprepare
commands programmatically. After these changes, the dist size forcreate-nuxt
can be reduced to approximately 4.2 MB!