fix(dev): use node pipelining on windows #1072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
reported in nuxt/nuxt#33410 (comment) and on Discord
β Type of change
π Description
issue reproduced for files > ~131kB on windows on fetchable dev server.
this is only true when returning node streams - which was reproducible b/c nuxt/devtools was using sirv under the hood - also reproducible with ipx (
<NuxtImg>was also mentioned)at the point a file is > ~131kb we hit a deadlock, where no more can be written into the named pipe, and nothing can be cleared out of the socket
this fix skips using undici in this case in favour of using native node
http