Skip to content

Conversation

@DamianGlowala
Copy link
Member

@DamianGlowala DamianGlowala commented Oct 30, 2025

πŸ”— Linked issue

resolves #1013

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adjusts addDependency's workspace option so that users can add a module to the pnpm's workspace root without seeing an error (or run upgrade command which also uses addDependency).

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@1109
npm i https://pkg.pr.new/nuxi@1109
npm i https://pkg.pr.new/@nuxt/cli@1109

commit: c88e5cd

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

πŸ“¦ Bundle Size Comparison

πŸ“ˆ nuxi

Metric Base Head Diff
Rendered 4297.71 KB 4298.20 KB +0.48 KB (+0.01%)

πŸ“ˆ nuxt-cli

Metric Base Head Diff
Rendered 120.80 KB 121.07 KB +0.27 KB (+0.22%)

πŸ“ˆ create-nuxt

Metric Base Head Diff
Rendered 2320.92 KB 2321.09 KB +0.18 KB (+0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 30, 2025

CodSpeed Performance Report

Merging #1109 will not alter performance

Comparing fix/pnpm-workspace-root (c88e5cd) with main (682b8ac)

Summary

βœ… 2 untouched

@danielroe
Copy link
Member

❀️

@danielroe danielroe changed the title fix: allow adding module to pnpm workspace root fix(module,upgrade): allow adding module to pnpm workspace root Oct 31, 2025
@danielroe danielroe changed the title fix(module,upgrade): allow adding module to pnpm workspace root fix(module,upgrade): allow adding module/nuxt version to pnpm workspace root Oct 31, 2025
@danielroe danielroe merged commit 6d1fedf into main Oct 31, 2025
12 checks passed
@danielroe danielroe deleted the fix/pnpm-workspace-root branch October 31, 2025 12:26
@github-actions github-actions bot mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot add a module in pnpm root workspaces

3 participants