-
Notifications
You must be signed in to change notification settings - Fork 100
feat: use clack to add more β¨ #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
π¦ Bundle Size Comparisonπ nuxi
π nuxt-cli
π create-nuxt
|
commit: |
CodSpeed Performance ReportMerging #1121 will not alter performanceComparing Summary
|
dreyfus92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks really good, dunno what are your thoughts on sticking with styleText rather than using picocolors? π
|
very happy to use picocolors (I did in an earlier version of the pr) what are the benefits to switching? |
|
trimming the dep tree like the lumberjack would suggest @43081j, |
|
ohh, I see what you mean! currently I'm using colors from |
packages/nuxi/src/commands/info.ts
Outdated
| boxStr += `${item}, ` | ||
| boxRowLength += itemLength | ||
| } | ||
| boxStr = `${boxStr.slice(0, -2)}\n` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a lot of this logic looks like it is figuring out terminal bounds etc
what exactly is this rendering? π i feel like most of this should use clack helpers one day, if/when they exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly - and i did look to see if it was exported but it wasn't
i'm using this to render columns in the box (so i have to know when to wrap)
if you want this in clack, i'll happily refactor this upstream





π Linked issue
#1078
β Type of change
π Description
This is a pretty thorough refactor of logging/prompting with the aim of improving the DX of using the CLI.
It's probably only the beginning as I think we need to improve consistency between commands (with colours, for example), and the line on the left side.
I'd also like to avoid printing more than a couple of lines to stdout (using the tasklog) when upgrading or building nuxt or installing dependencies - any ideas @43081j?
I've removed the global console setup as I think this is now not needed, but I'll need to test to see if this is really the case.much testing required π
π key questions
notevsboxnuxt infocommand). in some we addvprefix, in others notmodulesearch commandnuxt infocommand)I'd like to build a 'style language' for the CLI and document what we're aiming for.
π₯ notable improvements/changes
general
process.cwd()to wherever we are doing worknuxt addnuxt initvideo
CleanShot.2025-11-06.at.16.19.58.mp4
nuxt infobuildModulesunless someone's using bridgescreenshot
screenshot of complex project
example of formatted markdown
macOS 24.6.0Apple M2 Max (12 cores)v24.8.03.30.0pnpm@10.20.04.2.02.12.8rolldown-vite@7.1.20$development,app,colorMode,compatibilityDate,content,css,devtools,eslint,experimental,hooks,hub,icon,image,llms,mdc,modules,nitro,routeRules,sourcemap,turnstile,twoslash,typescript,ui@nuxt/ui@4.1.0,nuxt-content-twoslash@0.1.2,@nuxt/content@3.7.1,@nuxt/image@1.10.0,@nuxtjs/plausible@2.0.1,@nuxt/eslint@1.9.0,@nuxt/scripts@0.13.0,@nuxtjs/turnstile@1.1.1,@vueuse/nuxt@13.9.0,nuxt-og-image@5.1.12,motion-v/nuxt@1.7.4,nuxt-llms@0.1.3,@nuxthub/core@0.9.0,nuxt-charts@1.0.2,nuxt-auth-utils@0.5.25