Skip to content

Conversation

@yamachi4416
Copy link
Contributor

@yamachi4416 yamachi4416 commented Nov 15, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I noticed that specifying command-line options like https.cert and https.key wasn't taking effect, so I implemented a fix.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 15, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@1129
npm i https://pkg.pr.new/nuxi@1129
npm i https://pkg.pr.new/@nuxt/cli@1129

commit: d963b66

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

πŸ“¦ Bundle Size Comparison

πŸ“‰ nuxi

Metric Base Head Diff
Rendered 4463.69 KB 4463.36 KB -0.33 KB (-0.01%)

πŸ“‰ nuxt-cli

Metric Base Head Diff
Rendered 131.48 KB 131.45 KB -0.03 KB (-0.02%)

πŸ“‰ create-nuxt

Metric Base Head Diff
Rendered 2377.71 KB 2377.68 KB -0.03 KB (-0.00%)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@d5f9331). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/dev/utils.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage        ?   24.56%           
=======================================
  Files           ?       87           
  Lines           ?     4588           
  Branches        ?      245           
=======================================
  Hits            ?     1127           
  Misses          ?     3430           
  Partials        ?       31           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 15, 2025

CodSpeed Performance Report

Merging #1129 will not alter performance

Comparing yamachi4416:fix/dev-parse-listhen-options (d963b66) with main (d5f9331)

Summary

βœ… 2 untouched

@yamachi4416 yamachi4416 marked this pull request as ready for review November 15, 2025 01:22
description: 'Host to listen on (default: `NUXT_HOST || NITRO_HOST || HOST || nuxtOptions.devServer?.host`)',
},
'clipboard': { ...listhenArgs.clipboard, default: false },
'https.domains': {
Copy link
Contributor Author

@yamachi4416 yamachi4416 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed https.domains as it was identical to the original option's definition
listhen/cli.ts

@danielroe
Copy link
Member

danielroe commented Nov 15, 2025

would be nice to handle a couple of other cases in the tests/fix.

there are a couple of other reports, like this one in discord:

Hey All, my HTTPs server stopped working on Nuxt 4.2, did anyone else encounter this or have a fix?

NUXT_HOST=dev.com
NUXT_PORT=3000
NITRO_SSL_CERT=./dev.com.pem
NITRO_SSL_KEY=./dev.com.pem
nuxt dev --https

@yamachi4416 yamachi4416 force-pushed the fix/dev-parse-listhen-options branch from 06a7af1 to a361eae Compare November 16, 2025 04:00
@yamachi4416
Copy link
Contributor Author

thank you for your advice.
i have completed the following tasks

  1. host and port options to reference environment variables.
  2. added e2e test cases to verify configuration via environment variables
  3. added e2e test cases for the https option.
  4. added an https startup script to playground package.json.

i'd appreciate your review.

@yamachi4416 yamachi4416 force-pushed the fix/dev-parse-listhen-options branch from a361eae to 4d201b2 Compare November 16, 2025 05:00
@yamachi4416 yamachi4416 force-pushed the fix/dev-parse-listhen-options branch from 4d201b2 to d963b66 Compare November 16, 2025 05:27
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❀️

@danielroe danielroe merged commit 02d37f0 into nuxt:main Nov 16, 2025
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2025
@yamachi4416 yamachi4416 deleted the fix/dev-parse-listhen-options branch November 16, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants