Skip to content

Conversation

@yassilah
Copy link
Contributor

@yassilah yassilah commented Oct 21, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #525. It is pending another PR to add Deno support for nypm (unjs/nypm#158).

@yassilah yassilah requested a review from danielroe as a code owner October 21, 2024 20:33
@danielroe danielroe marked this pull request as draft October 22, 2024 12:17
@danielroe
Copy link
Member

this looks great - thank you ❀️

marking as draft until the upstream pr merges πŸ™

@pi0
Copy link
Member

pi0 commented Nov 26, 2024

nypm 0.4 is released with deno support, thanks!

@danielroe danielroe marked this pull request as ready for review November 28, 2024 11:55
@danielroe danielroe merged commit fc8ad74 into nuxt:main Nov 28, 2024
3 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a4f59f5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/commands/init.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #526   +/-   ##
======================================
  Coverage        ?   1.31%           
======================================
  Files           ?      44           
  Lines           ?    2813           
  Branches        ?      44           
======================================
  Hits            ?      37           
  Misses          ?    2734           
  Partials        ?      42           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@yassilah yassilah deleted the feat-deno branch November 29, 2024 08:13
@BlueskyFR BlueskyFR mentioned this pull request Dec 8, 2024
4 tasks
@BlueskyFR
Copy link

Hey @yassilah !
The Nuxt UI Deno starter template is broken right now, giving a 500 error when running in dev mode: [nuxt] [request error] [unhandled] [500] Cannot find module 'vue', maybe something is still missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Deno] Add Deno as a package manager

5 participants