Skip to content

fix(info): await loading of nuxt config file #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2024
Merged

fix(info): await loading of nuxt config file #528

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dc8171
fix: add await to resolve async function issue
selemondev Oct 22, 2024
bc49fc7
Merge branch 'main' into fix/await-function-bug
selemondev Oct 22, 2024
8158e0d
chore: revert change to lockfile
danielroe Oct 22, 2024
a939efb
chore: await `jiti.import`
danielroe Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/commands/info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default defineCommand({
const cwd = resolve(ctx.args.cwd || ctx.args.rootDir || '.')

// Load Nuxt config
const nuxtConfig = getNuxtConfig(cwd)
const nuxtConfig = await getNuxtConfig(cwd)

// Find nearest package.json
const { dependencies = {}, devDependencies = {} } = findPackage(cwd)
Expand Down Expand Up @@ -162,7 +162,7 @@ function normalizeConfigModule(
return null
}

function getNuxtConfig(rootDir: string) {
async function getNuxtConfig(rootDir: string) {
try {
const jiti = createJiti(rootDir, {
interopDefault: true,
Expand All @@ -173,7 +173,7 @@ function getNuxtConfig(rootDir: string) {
},
})
;(globalThis as any).defineNuxtConfig = (c: any) => c
const result = jiti.import('./nuxt.config') as NuxtConfig
const result = await jiti.import('./nuxt.config') as NuxtConfig
delete (globalThis as any).defineNuxtConfig
return result
}
Expand Down