Skip to content

Conversation

@BobbieGoede
Copy link
Member

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation or readme)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Resolves #551

Changes the generated api template path to be resolved from rootDir instead of srcDir if compatibilityVersion: 4, not sure if other templates should be from rootDir as well, let me know.

I also changed the template paths to use the config dir where applicable, not sure if there's an open issue for this ๐Ÿค”

@BobbieGoede BobbieGoede self-assigned this Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e49583f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/utils/templates.ts 45.00% 11 Missing โš ๏ธ
src/commands/add.ts 0.00% 6 Missing โš ๏ธ
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #586   +/-   ##
======================================
  Coverage        ?   1.29%           
======================================
  Files           ?      44           
  Lines           ?    2865           
  Branches        ?      44           
======================================
  Hits            ?      37           
  Misses          ?    2786           
  Partials        ?      42           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we also need to update the tests to pass the config

@danielroe danielroe changed the title fix: support dir and compatibilityVersion: 4 config fix(add): respect custom dirs from nuxt project Dec 7, 2024
@danielroe danielroe merged commit f5b51b5 into nuxt:main Dec 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuxt 4 Directory structure support

3 participants