Skip to content

Conversation

@BobbieGoede
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #542

Not sure if bug fix or feature, but it makes sense users want to run analyze using the same options as the build command (should analyze actually be an option/flag for the build command?).

I haven't actually tested whether the env file is being used, not sure what an easy way is to check this, but I simply applied the flag the same way as in the build command.

This PR also moves the --dot-env args into src/commands/_shared.ts like other common/shared flags.

@BobbieGoede BobbieGoede self-assigned this Dec 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@207d0f0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/commands/_shared.ts 0.00% 6 Missing ⚠️
src/commands/analyze.ts 0.00% 6 Missing ⚠️
src/commands/build.ts 0.00% 2 Missing ⚠️
src/commands/dev.ts 0.00% 2 Missing ⚠️
src/commands/generate.ts 0.00% 2 Missing ⚠️
src/commands/prepare.ts 0.00% 2 Missing ⚠️
src/commands/preview.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #589   +/-   ##
======================================
  Coverage        ?   1.29%           
======================================
  Files           ?      44           
  Lines           ?    2860           
  Branches        ?      44           
======================================
  Hits            ?      37           
  Misses          ?    2781           
  Partials        ?      42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@danielroe danielroe merged commit 588a76a into nuxt:main Dec 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxt analyze should accept --dotenv flag like nuxt build

3 participants