feat: use `jiti` to import/resolve modules #632

danielroe · 2025-01-05T23:44:43Z

🔗 Linked issue

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

this drops a lot of legacy code from nuxi that was using cjs utilities to import/resolve paths within nuxt

pkg-pr-new · 2025-01-06T00:00:19Z

Open in Stackblitz • nuxt-cli-playground

npm i https://pkg.pr.new/nuxi@632

commit: 00d50ae

github-actions · 2025-01-06T10:17:27Z

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
61 → 57	6.04 MB → 6.04 MB (-1.95 kB)	-0.03%

Changeset

File	Δ	Size
`src/utils/banner.ts`	📈 +43 B (+7.45%)	577 B → 620 B
`src/utils/kit.ts`	📈 +62 B (+7.23%)	857 B → 919 B
`src/commands/typecheck.ts`	📈 +55 B (+3.62%)	1.49 kB → 1.54 kB
`src/commands/dev.ts`	📈 +163 B (+2.32%)	6.87 kB → 7.03 kB
`src/utils/dev.ts`	📈 +38 B (+0.52%)	7.08 kB → 7.12 kB
`src/commands/build.ts`	📈 +6 B (+0.30%)	1.97 kB → 1.97 kB
`src/commands/module/add.ts`	📉 -2 B (-0.02%)	8.76 kB → 8.76 kB
`package.json`	📉 -18 B (-0.68%)	2.57 kB → 2.55 kB
`node_modules/mlly/dist/index.mjs`	📉 -922 B (-1.69%)	53.25 kB → 52.35 kB
`src/commands/build-module.ts`	📉 -28 B (-2.05%)	1.33 kB → 1.31 kB
`src/commands/prepare.ts`	📉 -22 B (-2.12%)	1.01 kB → 1014 B
`src/commands/info.ts`	📉 -235 B (-4.92%)	4.66 kB → 4.43 kB
`src/commands/module/_utils.ts`	📉 -99 B (-12.31%)	804 B → 705 B
`src/utils/fs.ts`	📉 -194 B (-14.58%)	1.3 kB → 1.11 kB
`src/utils/cjs.ts`	🔥 -524 B (-100%)	524 B → 0 B
`src/utils/esm.ts`	🔥 -315 B (-100%)	315 B → 0 B

View detailed bundle breakdown

Added

Asset	File Size	% Changed
shared/nuxi.CYpdwSAp.mjs	0 B → 298 kB (+298 kB)	-
shared/nuxi.CtyBaBLD.mjs	0 B → 149.92 kB (+149.92 kB)	-
shared/nuxi.u3D7OjKE.mjs	0 B → 124.96 kB (+124.96 kB)	-
shared/nuxi.B3-S04AU.mjs	0 B → 77.08 kB (+77.08 kB)	-
shared/nuxi.BweWRjcP.mjs	0 B → 20.07 kB (+20.07 kB)	-
shared/nuxi.COjw1VDj.mjs	0 B → 17.69 kB (+17.69 kB)	-
shared/nuxi.8sZGMTBu.mjs	0 B → 14.64 kB (+14.64 kB)	-
shared/nuxi.C9xI8-8a.mjs	0 B → 8.04 kB (+8.04 kB)	-
shared/nuxi.CpRVKTNR.mjs	0 B → 5.48 kB (+5.48 kB)	-
shared/nuxi.Brrbt9CE.mjs	0 B → 1.11 kB (+1.11 kB)	-
shared/nuxi.DpekDEZq.mjs	0 B → 1.04 kB (+1.04 kB)	-
shared/nuxi.B6KJ2n2c.mjs	0 B → 620 B (+620 B)	-

Removed

Asset	File Size	% Changed
shared/nuxi.B8Pgcsge.mjs	279.64 kB → 0 B (-279.64 kB)	-100%
shared/nuxi.BuB__Uwx.mjs	149.56 kB → 0 B (-149.56 kB)	-100%
shared/nuxi.CqngKnbG.mjs	123.04 kB → 0 B (-123.04 kB)	-100%
shared/nuxi.Bqz__fm8.mjs	77.1 kB → 0 B (-77.1 kB)	-100%
shared/nuxi.CWDSLZsO.mjs	20.07 kB → 0 B (-20.07 kB)	-100%
shared/nuxi.DKnwBmUk.mjs	17.69 kB → 0 B (-17.69 kB)	-100%
shared/nuxi.Dwt-SNw-.mjs	14.64 kB → 0 B (-14.64 kB)	-100%
shared/nuxi.o6SBGVuo.mjs	13.55 kB → 0 B (-13.55 kB)	-100%
shared/nuxi.gO8z-V6K.mjs	8.04 kB → 0 B (-8.04 kB)	-100%
shared/nuxi.wdP7YXM4.mjs	6.52 kB → 0 B (-6.52 kB)	-100%
shared/nuxi.8Y_ea1k_.mjs	5.71 kB → 0 B (-5.71 kB)	-100%
shared/nuxi.D_gC1ZD9.mjs	2.01 kB → 0 B (-2.01 kB)	-100%
shared/nuxi.DlqDy3Vc.mjs	1.3 kB → 0 B (-1.3 kB)	-100%
shared/nuxi.CNdZ4jUJ.mjs	577 B → 0 B (-577 B)	-100%
shared/nuxi.CvvoJqu1.mjs	524 B → 0 B (-524 B)	-100%
shared/nuxi.Caj71Dmg.mjs	315 B → 0 B (-315 B)	-100%

Bigger

Asset	File Size	% Changed
chunks/dev.mjs	9.46 kB → 9.61 kB (+163 B)	+1.68%
chunks/typecheck.mjs	1.49 kB → 1.54 kB (+55 B)	+3.62%
chunks/dev2.mjs	68.9 kB → 68.94 kB (+38 B)	+0.05%
chunks/build.mjs	1.97 kB → 1.97 kB (+6 B)	+0.30%

Smaller

Asset	File Size	% Changed
chunks/info.mjs	4.96 kB → 4.43 kB (-540 B)	-10.63%
chunks/build-module.mjs	1.33 kB → 1.31 kB (-28 B)	-2.05%
chunks/prepare.mjs	1.01 kB → 1014 B (-22 B)	-2.12%
chunks/add2.mjs	10.6 kB → 10.6 kB (-2 B)	-0.02%

Unchanged

Asset	File Size	% Changed
index.mjs	188 B	0%
chunks/prompt.mjs	46.05 kB	0%
chunks/add.mjs	4.52 kB	0%
chunks/analyze.mjs	3.2 kB	0%
chunks/cleanup.mjs	471 B	0%
chunks/dev-child.mjs	1.79 kB	0%
chunks/devtools.mjs	703 B	0%
chunks/generate.mjs	331 B	0%
chunks/init.mjs	803.84 kB	0%
chunks/index.mjs	274 B	0%
chunks/preview.mjs	2.8 kB	0%
chunks/test.mjs	1.17 kB	0%
chunks/upgrade.mjs	5.72 kB	0%
chunks/satisfies.mjs	116 B	0%
chunks/index2.mjs	909.09 kB	0%
chunks/index3.mjs	239.24 kB	0%
chunks/index4.mjs	17.11 kB	0%
chunks/xdg-open.mjs	25.32 kB	0%
chunks/node.mjs	134.34 kB	0%
chunks/index5.mjs	1.24 kB	0%
chunks/index6.mjs	6.55 kB	0%
chunks/index7.mjs	41.5 kB	0%
chunks/multipart-parser.mjs	5.11 kB	0%
chunks/search.mjs	43.01 kB	0%
chunks/index8.mjs	5.87 kB	0%
chunks/main.mjs	15.34 kB	0%
chunks/index9.mjs	882.9 kB	0%
chunks/multipart-parser2.mjs	4.58 kB	0%
shared/nuxi.CgS_bFBf.mjs	299 B	0%
shared/nuxi.BSm0_9Hr.mjs	107 B	0%
shared/nuxi.DdI-vRyV.mjs	1.54 kB	0%
shared/nuxi.DYqxF_9Q.mjs	28.76 kB	0%
shared/nuxi.7PA8W94y.mjs	2.02 MB	0%
shared/nuxi.E-ZsRS8r.mjs	943 B	0%
shared/nuxi.khUN-O-W.mjs	1.76 kB	0%
shared/nuxi.wVjcfr_F.mjs	27.14 kB	0%
shared/nuxi.BPuj-7ta.mjs	42.89 kB	0%

pi0 · 2025-01-06T11:02:37Z

src/commands/dev.ts

    overrideEnv('development')
    const cwd = resolve(ctx.args.cwd || ctx.args.rootDir)
-    showVersions(cwd)
+    await showVersions(cwd)


This was intentionally to block rest of build logic for informational information (iirc)

it wasn't previously async but we could make it non blocking

feat: use jiti to import/resolve modules

7966ebb

danielroe requested a review from pi0 January 5, 2025 23:45

danielroe added 2 commits January 5, 2025 23:49

Merge branch 'main' into fix/jiti

a4142e9

Merge branch 'main' into fix/jiti

978569e

danielroe added 6 commits January 6, 2025 00:13

fix(info): use pkg-types to read package info

b96a454

chore: remove unused import

4de3336

Merge branch 'main' into fix/jiti

e7402f7

Merge remote-tracking branch 'origin/main' into fix/jiti

d94e014

fix: allow failing to resolve package

4312187

Merge branch 'main' into fix/jiti

7402565

danielroe added 5 commits January 6, 2025 10:17

Merge branch 'main' into fix/jiti

8d425d0

Merge branch 'main' into fix/jiti

c7fb921

Merge branch 'main' into fix/jiti

a4b6dcd

Merge branch 'main' into fix/jiti

02db3a0

fix: try resolving deps from within nuxt dir

00d50ae

danielroe merged commit 2c1e14e into main Jan 6, 2025
7 checks passed

danielroe deleted the fix/jiti branch January 6, 2025 10:50

pi0 reviewed Jan 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: use `jiti` to import/resolve modules #632

feat: use `jiti` to import/resolve modules #632

Uh oh!

danielroe commented Jan 5, 2025

Uh oh!

pkg-pr-new bot commented Jan 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

pi0 Jan 6, 2025 •

edited

Loading

Uh oh!

danielroe Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: use jiti to import/resolve modules #632

feat: use jiti to import/resolve modules #632

Uh oh!

Conversation

danielroe commented Jan 5, 2025

🔗 Linked issue

❓ Type of change

📚 Description

Uh oh!

pkg-pr-new bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats

Uh oh!

Uh oh!

pi0 Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielroe Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: use `jiti` to import/resolve modules #632

feat: use `jiti` to import/resolve modules #632

pkg-pr-new bot commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025 •

edited

Loading

pi0 Jan 6, 2025 •

edited

Loading