Skip to content

perf: use tinyexec to execute commands #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

perf: use tinyexec to execute commands #639

merged 1 commit into from
Jan 6, 2025

Conversation

@danielroe
Copy link
Member

@danielroe danielroe commented Jan 6, 2025 •
edited
Loading

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this migrates to use https://github.com/tinylibs/tinyexec, which is tinier wrapper around node's child_process and a better choice for a minimal dist given that nuxi inlines its dependencies (currently)

@danielroe danielroe self-assigned this Jan 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
57 β†’ 55 6.04 MB β†’ 5.81 MB (-239.05 kB) -3.86%
Changeset (largest 100 files by percent change)
File Ξ” Size
src/commands/devtools.ts πŸ“ˆ +34 B (+4.84%) 703 B β†’ 737 B
src/commands/typecheck.ts πŸ“ˆ +73 B (+4.63%) 1.54 kB β†’ 1.61 kB
src/commands/init.ts πŸ“ˆ +34 B (+0.83%) 3.99 kB β†’ 4.02 kB
node_modules/npm-run-path/index.js πŸ“ˆ +8 B (+0.69%) 1.13 kB β†’ 1.14 kB
src/commands/preview.ts πŸ“ˆ +14 B (+0.49%) 2.8 kB β†’ 2.81 kB
node_modules/execa/lib/verbose.js πŸ“ˆ +2 B (+0.41%) 487 B β†’ 489 B
src/commands/build-module.ts πŸ“ˆ +5 B (+0.37%) 1.31 kB β†’ 1.31 kB
node_modules/execa/index.js πŸ“ˆ +14 B (+0.20%) 6.78 kB β†’ 6.79 kB
node_modules/merge-stream/index.js πŸ“ˆ +2 B (+0.18%) 1.07 kB β†’ 1.07 kB
package.json πŸ“ˆ +3 B (+0.11%) 2.55 kB β†’ 2.55 kB
node_modules/execa/lib/error.js πŸ“ˆ +2 B (+0.09%) 2.06 kB β†’ 2.07 kB
node_modules/execa/lib/command.js πŸ“ˆ +2 B (+0.07%) 2.81 kB β†’ 2.82 kB
node_modules/figures/index.js πŸ”₯ -6.72 kB (-100%) 6.72 kB β†’ 0 B
node_modules/execa/lib/stdio/handle.js πŸ”₯ -6.65 kB (-100%) 6.65 kB β†’ 0 B
node_modules/@sindresorhus/merge-streams/index.js πŸ”₯ -6.28 kB (-100%) 6.28 kB β†’ 0 B
node_modules/execa/lib/stdio/type.js πŸ”₯ -5.88 kB (-100%) 5.88 kB β†’ 0 B
node_modules/execa/lib/ipc/validation.js πŸ”₯ -5.49 kB (-100%) 5.49 kB β†’ 0 B
node_modules/execa/lib/resolve/wait-stream.js πŸ”₯ -4.9 kB (-100%) 4.9 kB β†’ 0 B
node_modules/execa/lib/methods/template.js πŸ”₯ -4.66 kB (-100%) 4.66 kB β†’ 0 B
node_modules/execa/lib/methods/main-async.js πŸ”₯ -4.62 kB (-100%) 4.62 kB β†’ 0 B
node_modules/pretty-ms/index.js πŸ”₯ -4.28 kB (-100%) 4.28 kB β†’ 0 B
node_modules/execa/lib/methods/main-sync.js πŸ”₯ -3.84 kB (-100%) 3.84 kB β†’ 0 B
node_modules/execa/lib/arguments/fd-options.js πŸ”₯ -3.81 kB (-100%) 3.81 kB β†’ 0 B
node_modules/execa/lib/stdio/duplicate.js πŸ”₯ -3.74 kB (-100%) 3.74 kB β†’ 0 B
node_modules/execa/lib/return/message.js πŸ”₯ -3.7 kB (-100%) 3.7 kB β†’ 0 B
node_modules/execa/lib/arguments/specific.js πŸ”₯ -3.49 kB (-100%) 3.49 kB β†’ 0 B
node_modules/execa/lib/arguments/escape.js πŸ”₯ -3.46 kB (-100%) 3.46 kB β†’ 0 B
node_modules/execa/lib/resolve/wait-subprocess.js πŸ”₯ -3.43 kB (-100%) 3.43 kB β†’ 0 B
node_modules/execa/lib/return/result.js πŸ”₯ -3.39 kB (-100%) 3.39 kB β†’ 0 B
node_modules/execa/lib/io/output-sync.js πŸ”₯ -3.38 kB (-100%) 3.38 kB β†’ 0 B
node_modules/execa/lib/stdio/native.js πŸ”₯ -3.38 kB (-100%) 3.38 kB β†’ 0 B
node_modules/execa/lib/io/iterate.js πŸ”₯ -3.28 kB (-100%) 3.28 kB β†’ 0 B
node_modules/execa/lib/convert/readable.js πŸ”₯ -3.27 kB (-100%) 3.27 kB β†’ 0 B
node_modules/execa/lib/transform/split.js πŸ”₯ -3.22 kB (-100%) 3.22 kB β†’ 0 B
node_modules/execa/lib/ipc/incoming.js πŸ”₯ -3.13 kB (-100%) 3.13 kB β†’ 0 B
node_modules/execa/lib/convert/writable.js πŸ”₯ -3.12 kB (-100%) 3.12 kB β†’ 0 B
node_modules/execa/lib/transform/generator.js πŸ”₯ -3.11 kB (-100%) 3.11 kB β†’ 0 B
node_modules/execa/lib/pipe/pipe-arguments.js πŸ”₯ -2.97 kB (-100%) 2.97 kB β†’ 0 B
node_modules/execa/lib/transform/normalize.js πŸ”₯ -2.97 kB (-100%) 2.97 kB β†’ 0 B
node_modules/execa/lib/ipc/strict.js πŸ”₯ -2.82 kB (-100%) 2.82 kB β†’ 0 B
node_modules/execa/lib/io/contents.js πŸ”₯ -2.77 kB (-100%) 2.77 kB β†’ 0 B
node_modules/execa/lib/io/output-async.js πŸ”₯ -2.68 kB (-100%) 2.68 kB β†’ 0 B
node_modules/execa/lib/terminate/kill.js πŸ”₯ -2.67 kB (-100%) 2.67 kB β†’ 0 B
node_modules/execa/lib/io/max-buffer.js πŸ”₯ -2.62 kB (-100%) 2.62 kB β†’ 0 B
node_modules/execa/lib/stdio/direction.js πŸ”₯ -2.56 kB (-100%) 2.56 kB β†’ 0 B
node_modules/execa/lib/verbose/output.js πŸ”₯ -2.42 kB (-100%) 2.42 kB β†’ 0 B
node_modules/execa/lib/terminate/signal.js πŸ”₯ -2.35 kB (-100%) 2.35 kB β†’ 0 B
node_modules/execa/lib/arguments/options.js πŸ”₯ -2.21 kB (-100%) 2.21 kB β†’ 0 B
node_modules/execa/lib/utils/uint-array.js πŸ”₯ -2.16 kB (-100%) 2.16 kB β†’ 0 B
node_modules/execa/lib/pipe/streaming.js πŸ”₯ -2.13 kB (-100%) 2.13 kB β†’ 0 B
node_modules/execa/lib/methods/create.js πŸ”₯ -2.1 kB (-100%) 2.1 kB β†’ 0 B
node_modules/execa/lib/stdio/stdio-option.js πŸ”₯ -2.06 kB (-100%) 2.06 kB β†’ 0 B
node_modules/execa/lib/ipc/send.js πŸ”₯ -2.03 kB (-100%) 2.03 kB β†’ 0 B
node_modules/execa/lib/ipc/outgoing.js πŸ”₯ -1.99 kB (-100%) 1.99 kB β†’ 0 B
node_modules/execa/lib/ipc/get-each.js πŸ”₯ -1.95 kB (-100%) 1.95 kB β†’ 0 B
node_modules/execa/lib/stdio/handle-async.js πŸ”₯ -1.88 kB (-100%) 1.88 kB β†’ 0 B
node_modules/execa/lib/pipe/setup.js πŸ”₯ -1.84 kB (-100%) 1.84 kB β†’ 0 B
node_modules/execa/lib/convert/duplex.js πŸ”₯ -1.82 kB (-100%) 1.82 kB β†’ 0 B
node_modules/execa/lib/stdio/handle-sync.js πŸ”₯ -1.79 kB (-100%) 1.79 kB β†’ 0 B
node_modules/execa/lib/verbose/log.js πŸ”₯ -1.79 kB (-100%) 1.79 kB β†’ 0 B
node_modules/execa/lib/transform/object-mode.js πŸ”₯ -1.77 kB (-100%) 1.77 kB β†’ 0 B
node_modules/get-stream/source/stream.js πŸ”₯ -1.77 kB (-100%) 1.77 kB β†’ 0 B
node_modules/execa/lib/terminate/graceful.js πŸ”₯ -1.74 kB (-100%) 1.74 kB β†’ 0 B
node_modules/execa/lib/ipc/forward.js πŸ”₯ -1.72 kB (-100%) 1.72 kB β†’ 0 B
node_modules/execa/lib/io/input-sync.js πŸ”₯ -1.72 kB (-100%) 1.72 kB β†’ 0 B
node_modules/execa/lib/resolve/exit-async.js πŸ”₯ -1.71 kB (-100%) 1.71 kB β†’ 0 B
node_modules/execa/lib/ipc/reference.js πŸ”₯ -1.71 kB (-100%) 1.71 kB β†’ 0 B
node_modules/@sec-ant/readable-stream/dist/ponyfill/asyncIterator.js πŸ”₯ -1.69 kB (-100%) 1.69 kB β†’ 0 B
node_modules/execa/lib/transform/run-async.js πŸ”₯ -1.63 kB (-100%) 1.63 kB β†’ 0 B
node_modules/execa/lib/ipc/graceful.js πŸ”₯ -1.63 kB (-100%) 1.63 kB β†’ 0 B
node_modules/execa/lib/ipc/get-one.js πŸ”₯ -1.6 kB (-100%) 1.6 kB β†’ 0 B
node_modules/execa/lib/transform/validate.js πŸ”₯ -1.57 kB (-100%) 1.57 kB β†’ 0 B
node_modules/execa/lib/resolve/all-async.js πŸ”₯ -1.55 kB (-100%) 1.55 kB β†’ 0 B
node_modules/execa/lib/verbose/values.js πŸ”₯ -1.51 kB (-100%) 1.51 kB β†’ 0 B
node_modules/execa/lib/return/final-error.js πŸ”₯ -1.46 kB (-100%) 1.46 kB β†’ 0 B
node_modules/execa/lib/methods/node.js πŸ”₯ -1.46 kB (-100%) 1.46 kB β†’ 0 B
node_modules/execa/lib/methods/command.js πŸ”₯ -1.44 kB (-100%) 1.44 kB β†’ 0 B
node_modules/execa/lib/arguments/encoding-option.js πŸ”₯ -1.44 kB (-100%) 1.44 kB β†’ 0 B
node_modules/execa/lib/return/early-error.js πŸ”₯ -1.44 kB (-100%) 1.44 kB β†’ 0 B
node_modules/execa/lib/transform/encoding-transform.js πŸ”₯ -1.42 kB (-100%) 1.42 kB β†’ 0 B
node_modules/execa/lib/verbose/info.js πŸ”₯ -1.39 kB (-100%) 1.39 kB β†’ 0 B
node_modules/execa/lib/pipe/throw.js πŸ”₯ -1.33 kB (-100%) 1.33 kB β†’ 0 B
node_modules/yoctocolors/base.js πŸ”₯ -1.3 kB (-100%) 1.3 kB β†’ 0 B
node_modules/execa/lib/transform/run-sync.js πŸ”₯ -1.29 kB (-100%) 1.29 kB β†’ 0 B
node_modules/execa/lib/verbose/default.js πŸ”₯ -1.27 kB (-100%) 1.27 kB β†’ 0 B
node_modules/execa/lib/methods/parameters.js πŸ”₯ -1.21 kB (-100%) 1.21 kB β†’ 0 B
node_modules/execa/lib/io/pipeline.js πŸ”₯ -1.16 kB (-100%) 1.16 kB β†’ 0 B
node_modules/parse-ms/index.js πŸ”₯ -1.12 kB (-100%) 1.12 kB β†’ 0 B
node_modules/execa/lib/resolve/stdio.js πŸ”₯ -1.11 kB (-100%) 1.11 kB β†’ 0 B
node_modules/execa/lib/stdio/input-option.js πŸ”₯ -1.11 kB (-100%) 1.11 kB β†’ 0 B
node_modules/execa/lib/convert/concurrent.js πŸ”₯ -1.05 kB (-100%) 1.05 kB β†’ 0 B
node_modules/execa/lib/convert/shared.js πŸ”₯ -1.03 kB (-100%) 1.03 kB β†’ 0 B
node_modules/execa/lib/ipc/methods.js πŸ”₯ -1.02 kB (-100%) 1.02 kB β†’ 0 B
node_modules/execa/lib/ipc/ipc-input.js πŸ”₯ -1.01 kB (-100%) 1.01 kB β†’ 0 B
node_modules/execa/lib/methods/script.js πŸ”₯ -993 B (-100%) 993 B β†’ 0 B
node_modules/execa/lib/pipe/sequence.js πŸ”₯ -942 B (-100%) 942 B β†’ 0 B
node_modules/execa/lib/ipc/buffer-messages.js πŸ”₯ -907 B (-100%) 907 B β†’ 0 B
node_modules/execa/lib/arguments/file-url.js πŸ”₯ -897 B (-100%) 897 B β†’ 0 B
node_modules/execa/lib/arguments/cwd.js πŸ”₯ -844 B (-100%) 844 B β†’ 0 B
node_modules/execa/lib/terminate/cancel.js πŸ”₯ -838 B (-100%) 838 B β†’ 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.7vzw0dLN.mjs 0 B β†’ 149.92 kB (+149.92 kB) -
shared/nuxi.BVTZ3azA.mjs 0 B β†’ 77.08 kB (+77.08 kB) -
shared/nuxi.CB73KUG6.mjs 0 B β†’ 17.69 kB (+17.69 kB) -
shared/nuxi.D0cLFyVK.mjs 0 B β†’ 1.11 kB (+1.11 kB) -
shared/nuxi.DGnlmSCL.mjs 0 B β†’ 620 B (+620 B) -

Removed

Asset File Size % Changed
chunks/index9.mjs 882.9 kB β†’ 0 B (-882.9 kB) -100%
shared/nuxi.CtyBaBLD.mjs 149.92 kB β†’ 0 B (-149.92 kB) -100%
shared/nuxi.B3-S04AU.mjs 77.08 kB β†’ 0 B (-77.08 kB) -100%
shared/nuxi.DYqxF_9Q.mjs 28.76 kB β†’ 0 B (-28.76 kB) -100%
shared/nuxi.COjw1VDj.mjs 17.69 kB β†’ 0 B (-17.69 kB) -100%
shared/nuxi.Brrbt9CE.mjs 1.11 kB β†’ 0 B (-1.11 kB) -100%
shared/nuxi.B6KJ2n2c.mjs 620 B β†’ 0 B (-620 B) -100%

Bigger

Asset File Size % Changed
chunks/index8.mjs 5.87 kB β†’ 882.9 kB (+877.03 kB) +14940.58%
chunks/index6.mjs 6.55 kB β†’ 70.29 kB (+63.74 kB) +972.90%
chunks/index5.mjs 1.24 kB β†’ 6.55 kB (+5.32 kB) +429.94%
chunks/typecheck.mjs 1.54 kB β†’ 1.61 kB (+73 B) +4.63%
chunks/devtools.mjs 703 B β†’ 737 B (+34 B) +4.84%
chunks/init.mjs 803.84 kB β†’ 803.87 kB (+34 B) +0.00%
chunks/preview.mjs 2.8 kB β†’ 2.81 kB (+14 B) +0.49%
chunks/build-module.mjs 1.31 kB β†’ 1.31 kB (+5 B) +0.37%

Smaller

Asset File Size % Changed
chunks/index3.mjs 239.24 kB β†’ 17.11 kB (-222.13 kB) -92.85%
chunks/index7.mjs 41.5 kB β†’ 5.87 kB (-35.63 kB) -85.86%
chunks/index4.mjs 17.11 kB β†’ 1.24 kB (-15.88 kB) -92.78%

Unchanged

Asset File Size % Changed
index.mjs 188 B 0%
chunks/prompt.mjs 46.05 kB 0%
chunks/add.mjs 4.52 kB 0%
chunks/analyze.mjs 3.2 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.79 kB 0%
chunks/dev.mjs 9.61 kB 0%
chunks/generate.mjs 331 B 0%
chunks/info.mjs 4.43 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 1014 B 0%
chunks/test.mjs 1.17 kB 0%
chunks/upgrade.mjs 5.72 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/index2.mjs 909.09 kB 0%
chunks/dev2.mjs 68.94 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.34 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 10.6 kB 0%
chunks/search.mjs 43.01 kB 0%
chunks/main.mjs 15.34 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.CgS_bFBf.mjs 299 B 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.DdI-vRyV.mjs 1.54 kB 0%
shared/nuxi.BweWRjcP.mjs 20.07 kB 0%
shared/nuxi.8sZGMTBu.mjs 14.64 kB 0%
shared/nuxi.C9xI8-8a.mjs 8.04 kB 0%
shared/nuxi.7PA8W94y.mjs 2.02 MB 0%
shared/nuxi.CpRVKTNR.mjs 5.48 kB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.DpekDEZq.mjs 1.04 kB 0%
shared/nuxi.khUN-O-W.mjs 1.76 kB 0%
shared/nuxi.CYpdwSAp.mjs 298 kB 0%
shared/nuxi.wVjcfr_F.mjs 27.14 kB 0%
shared/nuxi.BPuj-7ta.mjs 42.89 kB 0%
shared/nuxi.u3D7OjKE.mjs 124.96 kB 0%

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz β€’ nuxt-cli-playground

npm i https://pkg.pr.new/nuxi@639

commit: 261e9dc

@danielroe danielroe merged commit bef8b64 into main Jan 6, 2025
7 checks passed
@danielroe danielroe deleted the perf/tinyexec branch January 6, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danielroe danielroe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe