Skip to content

fix: throw when errors are encountered #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2025
Merged

fix: throw when errors are encountered #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f8258
fix: throw when errors are encountered
danielroe Jan 11, 2025
a714ab3
chore: except tests we expect to fail
danielroe Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/release.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ for (const [DISTRIBUTION, pkg] of Object.entries(distributions)) {
}

// clean up
x('git', ['restore', 'package.json'])
x('git', ['restore', 'package.json'], {
nodeOptions: { stdio: 'inherit' },
throwOnError: true,
})
1 change: 1 addition & 0 deletions src/commands/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export default defineCommand({
'npx',
['@nuxt/devtools-wizard@latest', ctx.args.command, cwd],
{
throwOnError: true,
nodeOptions: {
stdio: 'inherit',
cwd,
Expand Down
5 changes: 4 additions & 1 deletion src/commands/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ export default defineCommand({
logger.info(`Starting preview command: \`${nitroJSON.commands.preview}\``)
const [command, ...commandArgs] = nitroJSON.commands.preview.split(' ')
logger.log('')
await x(command, commandArgs, { nodeOptions: { stdio: 'inherit', cwd: outputPath } })
await x(command, commandArgs, {
throwOnError: true,
nodeOptions: { stdio: 'inherit', cwd: outputPath },
})
},
})
12 changes: 10 additions & 2 deletions src/commands/typecheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export default defineCommand({
])
if (resolvedTypeScript && resolvedVueTsc) {
await x(fileURLToPath(resolvedVueTsc), ['--noEmit'], {
throwOnError: true,
nodeOptions: {
stdio: 'inherit',
cwd,
Expand All @@ -59,10 +60,14 @@ export default defineCommand({
await x(
'bun',
'install typescript vue-tsc --global --silent'.split(' '),
{ nodeOptions: { stdio: 'inherit', cwd } },
{
throwOnError: true,
nodeOptions: { stdio: 'inherit', cwd },
},
)

await x('bunx', 'vue-tsc --noEmit'.split(' '), {
throwOnError: true,
nodeOptions: {
stdio: 'inherit',
cwd,
Expand All @@ -73,7 +78,10 @@ export default defineCommand({
await x(
'npx',
'-p vue-tsc -p typescript vue-tsc --noEmit'.split(' '),
{ nodeOptions: { stdio: 'inherit', cwd } },
{
throwOnError: true,
nodeOptions: { stdio: 'inherit', cwd },
},
)
}
}
Expand Down
2 changes: 2 additions & 0 deletions test/e2e/commands.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ describe('commands', () => {
const file = join(fixtureDir, 'server/api/test.ts')
await rm(file, { force: true })
await x('nuxi', ['add', 'api', 'test'], {
throwOnError: true,
nodeOptions: { stdio: 'pipe', cwd: fixtureDir },
})
expect(existsSync(file)).toBeTruthy()
Expand All @@ -45,6 +46,7 @@ describe('commands', () => {
await rm(installPath, { recursive: true, force: true })
try {
await x('nuxi', ['init', installPath, `--packageManager=${pm}`, '--gitInit=false', '--preferOffline', '--install=false'], {
throwOnError: true,
nodeOptions: { stdio: 'inherit', cwd: fixtureDir },
})
const files = await readdir(installPath).catch(() => [])
Expand Down
Loading