Skip to content

Conversation

@danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#30725

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this automatically sets the new allowedHosts vite option when used with an explicit --host

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
29 77.87 kB β†’ 78.62 kB (+764 B) +0.96%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/commands/dev-child.ts πŸ“ˆ +349 B (+19.40%) 1.76 kB β†’ 2.1 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts πŸ“ˆ +415 B (+5.79%) 7 kB β†’ 7.4 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/dev.mjs 7 kB β†’ 7.4 kB (+415 B) +5.79%
chunks/dev-child.mjs 1.76 kB β†’ 2.1 kB (+349 B) +19.40%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 200 B 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/init.mjs 5.21 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 2.84 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/dev2.mjs 7.26 kB 0%
chunks/add2.mjs 11.79 kB 0%
chunks/search.mjs 2.94 kB 0%
shared/cli.ZjQ19XGU.mjs 5.48 kB 0%
shared/cli.mEn9q49T.mjs 804 B 0%
shared/cli.BnJuNnzK.mjs 294 B 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.DlcAx0De.mjs 1.04 kB 0%
shared/cli.Bc1MVia1.mjs 1.23 kB 0%
shared/cli.tKPzVzbf.mjs 836 B 0%
shared/cli.Bzv_ksqZ.mjs 107 B 0%
shared/cli.C935N1ss.mjs 687 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2025

Bundle Stats β€” create-nuxt-app size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
6 1.03 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.01 kB 0%
chunks/index.mjs 70.29 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/satisfies.mjs 43 kB 0%
shared/create-nuxt-app.DGIhHoEU.mjs 897.33 kB 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
54 5.67 MB β†’ 5.67 MB (+764 B) +0.01%
Changeset
File Ξ” Size
src/commands/dev-child.ts πŸ“ˆ +349 B (+19.45%) 1.75 kB β†’ 2.09 kB
src/commands/dev.ts πŸ“ˆ +415 B (+5.79%) 7 kB β†’ 7.4 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
chunks/dev.mjs 9.58 kB β†’ 9.99 kB (+415 B) +4.23%
chunks/dev-child.mjs 1.75 kB β†’ 2.09 kB (+349 B) +19.45%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 188 B 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/init.mjs 805.49 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 2.84 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.34 kB 0%
chunks/index2.mjs 909.09 kB 0%
chunks/dev2.mjs 69.1 kB 0%
chunks/index3.mjs 17.08 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.34 kB 0%
chunks/index4.mjs 1.24 kB 0%
chunks/index5.mjs 6.55 kB 0%
chunks/index6.mjs 70.29 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 11.98 kB 0%
chunks/search.mjs 42.99 kB 0%
chunks/index7.mjs 5.87 kB 0%
chunks/index8.mjs 886.32 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.BqbbTtZ1.mjs 76.16 kB 0%
shared/nuxi.BX35bYtK.mjs 804 B 0%
shared/nuxi.C06cIqym.mjs 294 B 0%
shared/nuxi.DdI-vRyV.mjs 1.54 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.jHNMu6i2.mjs 1.34 kB 0%
shared/nuxi.CeDCJTol.mjs 18.95 kB 0%
shared/nuxi.BwIereCt.mjs 17.68 kB 0%
shared/nuxi.CVCE_T29.mjs 836 B 0%
shared/nuxi.D0__QBAb.mjs 14.64 kB 0%
shared/nuxi.Cb8SV1Ml.mjs 6.13 kB 0%
shared/nuxi.WdkwsuT4.mjs 8.87 kB 0%
shared/nuxi.SEuYCQjN.mjs 2.02 MB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.BgENdoyd.mjs 1.76 kB 0%
shared/nuxi.CDPIBJHk.mjs 152.13 kB 0%
shared/nuxi.DsJ8r8e5.mjs 285.08 kB 0%
shared/nuxi.ChFrgAY-.mjs 5.71 kB 0%
shared/nuxi.CDQkQpHL.mjs 5.09 kB 0%
shared/nuxi.BPuj-7ta.mjs 42.89 kB 0%

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 25, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@704
npm i https://pkg.pr.new/nuxi@704
npm i https://pkg.pr.new/@nuxt/cli@704

commit: b2bef6f

@danielroe danielroe merged commit e56dab7 into main Jan 26, 2025
11 checks passed
@danielroe danielroe deleted the fix/allowed-hosts branch January 26, 2025 20:24
@danielroe danielroe mentioned this pull request Jan 28, 2025
This was referenced Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HMR broken with custom domain since Vite v5.4.12 / v6

3 participants