Skip to content

fix(init): improve interactive modules selector #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix(init): improve interactive modules selector #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions packages/nuxi/src/commands/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { x } from 'tinyexec'
import { runCommand } from '../run'
import { nuxtIcon, themeColor } from '../utils/ascii'
import { logger } from '../utils/logger'
import { cwdArgs } from './_shared'
import { cwdArgs, logLevelArgs } from './_shared'

const DEFAULT_REGISTRY = 'https://raw.githubusercontent.com/nuxt/starter/templates/templates'
const DEFAULT_TEMPLATE_NAME = 'v3'
Expand All @@ -39,6 +39,7 @@ export default defineCommand({
},
args: {
...cwdArgs,
...logLevelArgs,
dir: {
type: 'positional',
description: 'Project directory',
Expand Down Expand Up @@ -245,15 +246,14 @@ export default defineCommand({
}>('https://api.nuxt.com/modules')

const officialModules = response.modules
.filter(module => module.type === 'official')
.filter(module => module.npm !== '@nuxt/devtools')
.filter(module => module.type === 'official' && module.npm !== '@nuxt/devtools')

const selectedOfficialModules = await logger.prompt(
`Would you like to install any of the official modules?`,
{
type: 'multiselect',
options: officialModules.map(module => ({
label: `${colors.bold(colors.greenBright(module.npm))} – ${module.description.split('.')[0]}`,
label: `${colors.bold(colors.greenBright(module.npm))} – ${module.description.replace(/\.$/, '')}`,
value: module.npm,
})),
required: false,
Expand All @@ -271,14 +271,15 @@ export default defineCommand({

// Add modules
if (modulesToAdd.length > 0) {
await runCommand('module', [
const args: string[] = [
'add',
...modulesToAdd,
'--cwd',
join(ctx.args.cwd, ctx.args.dir),
'--skipInstall',
ctx.args.install ? 'false' : 'true',
])
`--cwd=${join(ctx.args.cwd, ctx.args.dir)}`,
ctx.args.install ? '' : '--skipInstall',
ctx.args.logLevel ? `--logLevel=${ctx.args.logLevel}` : '',
].filter(Boolean)

await runCommand('module', args)
}

// Display next steps
Expand Down
9 changes: 6 additions & 3 deletions packages/nuxi/src/commands/module/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,12 @@ export default defineCommand({

await addModules(resolvedModules, { ...ctx.args, cwd }, projectPkg)

// update the types for new module
const args = Object.entries(ctx.args).filter(([k]) => k in cwdArgs || k in logLevelArgs).map(([k, v]) => `--${k}=${v}`)
await runCommand('prepare', args)
// Run prepare command if install is not skipped
if (!ctx.args.skipInstall) {
const args = Object.entries(ctx.args).filter(([k]) => k in cwdArgs || k in logLevelArgs).map(([k, v]) => `--${k}=${v}`)

await runCommand('prepare', args)
}
},
})

Expand Down