-
Notifications
You must be signed in to change notification settings - Fork 100
fix(module): resolve semver module versions #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module): resolve semver module versions #803
Conversation
commit: |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
=======================================
Coverage ? 13.40%
=======================================
Files ? 68
Lines ? 3476
Branches ? 99
=======================================
Hits ? 466
Misses ? 2979
Partials ? 31 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
|
Awesome, I just tested it, but it doesn't work with minor versions: |
|
@maximepvrt @danielroe all set and done guys ππ» |
danielroe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me! let me know if I've missed something in your implementation when porting it to use semver ranges π
|
@danielroe sure, i was making some experiments on using semver lib but could not finish that, as soon as i can i will update that. |
|
no worries! i pushed directly |
π Linked issue
Fix for #697
β Type of change
π Description
The code verify if the
pkgVersionis only a single number to then perform a search for the highest major version.Previously PR fix part of the problem but not allow to install full package from a single major version.

This PR enhance the
nuxi module addto allowing it to find a Nuxt Module full version when only a major is specified.Without this PR:
With this PR:
Regression: