Skip to content

Conversation

@hacknug
Copy link
Contributor

@hacknug hacknug commented Apr 9, 2025

πŸ”— Linked issue

None.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR removes the spaces around nuxi in the logger to make it consistent with nuxt and other modules.

Here's an example of the logs when running postinstall:

Before

(base) nestor@MacBookPro woonuxt % ni
Lockfile is up to date, resolution step is skipped
Already up to date
. postinstall$ nuxt prepare
β”‚ [nuxt:tailwindcss] β„Ή Using default Tailwind CSS file
β”‚ β„Ή Nuxt Icon server bundle mode is set to local
β”‚ βœ” Nuxt Icon discovered local-installed 2 collections: heroicons, ion
β”‚ [nuxt] β„Ή Running with compatibility version 4
β”‚ [ nuxi ] βœ” Types generated in .nuxt
└─ Done in 13s
Done in 15.6s using pnpm v10.8.0

After

(base) nestor@MacBookPro woonuxt % ni
Lockfile is up to date, resolution step is skipped
Already up to date
. postinstall$ nuxt prepare
β”‚ [nuxt:tailwindcss] β„Ή Using default Tailwind CSS file
β”‚ β„Ή Nuxt Icon server bundle mode is set to local
β”‚ βœ” Nuxt Icon discovered local-installed 2 collections: heroicons, ion
β”‚ [nuxt] β„Ή Running with compatibility version 4
β”‚ [nuxi] βœ” Types generated in .nuxt
└─ Done in 13.1s
Done in 15.7s using pnpm v10.8.0

Feel free to close or request changes as you see fit.

@hacknug hacknug requested a review from danielroe as a code owner April 9, 2025 11:37
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/create-nuxt@847
npm i https://pkg.pr.new/nuxi@847
npm i https://pkg.pr.new/@nuxt/cli@847

commit: 1f554f7

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@ef582b0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/dev.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage        ?   12.99%           
=======================================
  Files           ?       69           
  Lines           ?     3587           
  Branches        ?      100           
=======================================
  Hits            ?      466           
  Misses          ?     3090           
  Partials        ?       31           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe changed the title style: remove space around nuxi in logger fix: remove color from nuxi tag in logger Apr 14, 2025
@danielroe danielroe merged commit b209c6b into nuxt:main Apr 14, 2025
8 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants