Skip to content

Conversation

@pi0
Copy link
Member

@pi0 pi0 commented Jun 1, 2020

Use globby (based on fast-glob)

@pi0 pi0 requested review from atinux and kevinmarrec June 1, 2020 12:03
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files           5        5           
  Lines         103      103           
  Branches       18       19    +1     
=======================================
  Hits           97       97           
  Misses          6        6           
Impacted Files Coverage Δ
src/scan.ts 97.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d0ff3...b3bf66d. Read the comment docs.

Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If globby is better let's go

@pi0 pi0 merged commit cdac9b9 into master Jun 1, 2020
@pi0 pi0 deleted the feat/globby branch June 1, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants