-
-
Notifications
You must be signed in to change notification settings - Fork 44
feat!: prefix components in nested dirs with full path #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 86.12% 86.44% +0.31%
==========================================
Files 7 7
Lines 173 177 +4
Branches 46 48 +2
==========================================
+ Hits 149 153 +4
Misses 24 24
Continue to review full report at Codecov.
|
|
@pi0 I thought we didn't want to prefix nested dirs when no duplicated components have been found in other components paths, no ? |
|
@kevinmarrec Yes we do warn about duplicated names. Also, it is better that people using distinct names for components (like This PR is to prefix properly for nested dirs like we currently automatically for one level only :) To de-prefix, we can specify sub-dirs in config. |
|
@pi0 Hum.. for my project at work our components have each a folder with same name that contains |
|
@kevinmarrec Actually multifile is still supported to split components :D But seems it is going to be a breaking change. Will move behind a flag for 1.x. |
atinux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to merge behind a flag to start :)
|
Might be nice to update the documentation I suppose |
kevinmarrec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good for the flag :)
|
Would love to see this merged! |
|
@pi0 whats happening with this? Any reason it hasn't been merged yet? |
|
@drewbaker we did not merge it yet because it is actually a breaking change and will have to be a major version 😬 |
Resolves #67. Despite the documentation, we were not properly resolving component names from nested directories resulting in duplicate names. This PR is probably introducing regression in usage for current users so would be probably introduce at least as feat.
components/form/input/text.vue<InputText><FormInputText>