Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 96.22% 97.84% +1.62%
==========================================
Files 7 14 +7
Lines 159 372 +213
Branches 40 77 +37
==========================================
+ Hits 153 364 +211
- Misses 6 8 +2
Continue to review full report at Codecov.
|
|
Nice idea! But without #81 (full prefix) this is a breaking change since we change behavior by using component from longest path to component with shortest path (actually i think we can have same behavior by changing sort) |
|
Agreed with @pi0 comment. Something we can do is integrating #81 (full prefix) as default for 2.x with an opt-out flag, and eventually making it opt-in for 1.x first as suggested by @pi0 in the full prefix PR. We will probably need 2 behaviors concerning this PR (overwriting components) too, depending if full prefix is enabled or not, so it works in both case, OR only have this feature working with full prefix enabled. EDIT : Btw cool feature @atinux :) ! |
|
I would love to have it. It is crucial for building bigger apps. Is there any workaround for now? How to override components or specific that eg for this folder components have higher priority? |
|
@pperzyna we need to release a new version of @nuxt/components before being able to merge this ;) |
The idea came to allow user to overwrites components in the Nuxt Docs Theme: nuxt/content#542
With this PR, we can now have:
node_modules/ my-theme/ components/ Header.vue components/ Header.vueThen defining in the
nuxt.config:Our
components/Header.vuewill overwrites our theme component if defined since the lowest level overwrites.