Skip to content

Conversation

@acidjazz
Copy link
Contributor

@acidjazz acidjazz commented Jul 16, 2025

πŸ”— Linked issue

resolves #3463

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Jul 16, 2025

@acidjazz is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 16, 2025

npm i https://pkg.pr.new/@nuxt/content@3464

commit: 3a94df9

@acidjazz
Copy link
Contributor Author

acidjazz commented Jul 16, 2025

npm i https://pkg.pr.new/@nuxt/content@3464

commit: 4569f31

This forced break-return fix has been confirmed to resolve our issue, the two INSERTS are now on their own line and the blog entries are no longer missing

Copy link

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@farnabaz
Copy link
Member

farnabaz commented Jul 17, 2025

I'm curious to know how is this happening πŸ€” In the template generation we join all lines with \n.

export const fullDatabaseRawDumpTemplate = (manifest: Manifest) => ({
filename: moduleTemplates.fullRawDump,
getContents: ({ options }: { options: { manifest: Manifest } }) => {
return Object.entries(options.manifest.dump).map(([_key, value]) => {
return value.join('\n')
}).join('\n')
},
write: true,
options: {
manifest,
},
})

Is there any simple reproduction to dig the issue?

@acidjazz
Copy link
Contributor Author

I'm curious to know how is this happening πŸ€” In the template generation we join all lines with \n.

export const fullDatabaseRawDumpTemplate = (manifest: Manifest) => ({
filename: moduleTemplates.fullRawDump,
getContents: ({ options }: { options: { manifest: Manifest } }) => {
return Object.entries(options.manifest.dump).map(([_key, value]) => {
return value.join('\n')
}).join('\n')
},
write: true,
options: {
manifest,
},
})

Is there any simple reproduction to dig the issue?

I wasn't able to get that going since we have almost 200 blog entries :/ - but i can tell you this is working on our end!

@farnabaz
Copy link
Member

@acidjazz I pushed a commit to your PR. Can you confirm that it works as expected with my commit?

@acidjazz
Copy link
Contributor Author

@acidjazz I pushed a commit to your PR. Can you confirm that it works as expected with my commit?

I will confirm in the next hour or so

@acidjazz
Copy link
Contributor Author

@acidjazz I pushed a commit to your PR. Can you confirm that it works as expected with my commit?

This is confirmed working on our end

@farnabaz farnabaz merged commit 4983443 into nuxt:main Jul 22, 2025
3 of 4 checks passed
@acidjazz acidjazz deleted the insert-force-breakline branch July 22, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

collection query util makes INSERTS w/out a newline sometimes

3 participants