feat: ref/reactive outside vue/nuxtApp context detection #89
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cernymatej
reviewed
Nov 12, 2025
Comment on lines
+2
to
+7
|
|
||
| ref('memory-leak-warning-shown') | ||
|
|
||
| export default defineNuxtPlugin(() => { | ||
| // Show memory leak warning | ||
| }) |
Member
There was a problem hiding this comment.
just for my own understanding - if you wouldn't mind explaining - how does this create a memory leak?
I thought that the ref would be created once and obviously kept in memory, but not consume more memory with subsequent requests.
Isn't it just unsafe in terms of cross-request state pollution?
Member
Author
There was a problem hiding this comment.
usually, when users uses ref outside a vue context, they tends to attach theses references to request events and array and so on.
It's also unsafe in term of XRSP. I admit i had a bit of a tunnel vision here since i'm a bit traumatized by memleaks 🤣
Let's change the wording to XRSP instead. It's way more accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolve #29
❓ Type of change
📚 Description
@danielroe any opinion about this ?