Skip to content

feat: support baseUrl and remove port :443 and :80 when http or https#103

Merged
pi0 merged 1 commit intonuxt:devfrom
ricardogobbosouza:feat-support-baseUrl
Jun 3, 2020
Merged

feat: support baseUrl and remove port :443 and :80 when http or https#103
pi0 merged 1 commit intonuxt:devfrom
ricardogobbosouza:feat-support-baseUrl

Conversation

@ricardogobbosouza
Copy link
Copy Markdown
Contributor

Resolve #100

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #103 into dev will decrease coverage by 4.92%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #103      +/-   ##
==========================================
- Coverage   95.83%   90.90%   -4.93%     
==========================================
  Files           1        1              
  Lines          48       55       +7     
  Branches       27       30       +3     
==========================================
+ Hits           46       50       +4     
- Misses          2        5       +3     
Impacted Files Coverage Δ
lib/module.js 90.90% <62.50%> (-4.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408322c...2c84c5e. Read the comment docs.

Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💚 Thanks

@pi0 pi0 merged commit fc3e78e into nuxt:dev Jun 3, 2020
@ricardogobbosouza ricardogobbosouza deleted the feat-support-baseUrl branch June 3, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make port optional

3 participants