fix(nuxt): delete nuxtApp._runningTransition onResolve

[kyumoon]

🔗 Linked issue

resolves #33024

📚 Description

This PR fixes an issue where nuxtApp._runningTransition was not being reset when navigating between a page with a transition and one without under specific conditions. For more details, please refer to the linked issue.

To resolve this, I've added code to the onResolve hook to properly clear the nuxtApp._runningTransition flag.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[pkg-pr-new]

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33025

nuxt

npm i https://pkg.pr.new/nuxt@33025

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33025

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33025

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33025

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33025

commit: 75d1573

[codspeed-hq]

CodSpeed Performance Report

Merging #33025 will not alter performance

_{Comparing kyumoon:fix/scrollToTop (75d1573) with main (6f4da1b)}

Summary

✅ 10 untouched benchmarks

[danielroe]

would you be able to add a runtime/unit regression test for this? (we have some scrollBehavior transition tests you can use as an example)

[kyumoon]

would you be able to add a runtime/unit regression test for this? (we have some scrollBehavior transition tests you can use as an example)

Okay, I pushed the test code.

[danielroe]

Thank you! ❤️

Would you mind updating your branch? I did some work on that test file in 5d78366.

[kyumoon]

Thank you! ❤️

Would you mind updating your branch? I did some work on that test file in 5d78366.

I was a bit confused if you wanted me to update the entire file with your code, so I've gone ahead and done that for now.

[danielroe]

@kyumoon the test file was renamed and updated, and an issue I hadn't spotted is that this PR was made against 3.x.

• would you rebase this PR against main branch?
• would you add a regression test to router.options.test.ts to cover the desired behaviour/fix that this PR adds?

[kyumoon]

@kyumoon the test file was renamed and updated, and an issue I hadn't spotted is that this PR was made against 3.x.

• would you rebase this PR against main branch?
• would you add a regression test to router.options.test.ts to cover the desired behaviour/fix that this PR adds?

I've changed the target branch to main and added the test code.

[coderabbitai]

Warning

Rate limit exceeded

@danielroe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6f4da1b and 75d1573.

📒 Files selected for processing (2)

• packages/nuxt/src/pages/runtime/page.ts (1 hunks)
• test/nuxt/router.options.test.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[danielroe]

thank you!

[IgorKha]

check this please

#33024 (comment)