Skip to content

Conversation

KazariEX
Copy link
Member

🔗 Linked issue

fix #32768

📚 Description

app/app.config.ts is imported by types/nitro-config.d.ts, so the app config needs to be properly argumented in the server context.

I also wonder why useAppConfig in nitropack returns any instead of AppConfig.

@KazariEX KazariEX requested a review from danielroe as a code owner September 21, 2025 21:07
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Sep 21, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33287

nuxt

npm i https://pkg.pr.new/nuxt@33287

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33287

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33287

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33287

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33287

commit: 9f817d9

Copy link

codspeed-hq bot commented Sep 21, 2025

CodSpeed Performance Report

Merging #33287 will not alter performance

Comparing KazariEX:fix/issue-32768 (9f817d9) with main (dc69e26)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on main (78d45c1) during the generation of this report, so dc69e26 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@danielroe
Copy link
Member

in retrospect we should probably have moved app.config.ts to shared/ instead of app/ 🤔

@danielroe danielroe merged commit 73627c9 into nuxt:main Sep 23, 2025
47 checks passed
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
@KazariEX KazariEX deleted the fix/issue-32768 branch September 23, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useAppConfig lose types from nuxt schema with new tsconfig

2 participants