-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix(nuxt): support v-slot:fallback
longform syntax in <DevOnly>
#33368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe DevOnlyPlugin transform in packages/nuxt/src/core/plugins/dev-only.ts now recognises the fallback slot via three syntaxes: fallback, #fallback, and v-slot:fallback. It also changes how the replacement slice start is computed, using fallback.loc.at(-1).start instead of array length indexing. No other logic, control flow, or exported declarations were altered. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@nuxt/kit
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
CodSpeed Performance ReportMerging #33368 will not alter performanceComparing Summary
|
🔗 Linked issue
N/A
📚 Description
<DevOnly>
previously supported only the shorthand slot syntax#fallback
. This PR extends support to the longformv-slot:fallback
syntax.