fix: validate required registry fields after runtime merge (#762)

Co-authored-by: Harlan Wilton <harlan@harlanzw.com>

Author: tsukiyama-3

packages/script/src/module.ts

@@ -280,6 +280,20 @@ export function resolveConfiguredProxyDomains(
   return [...domains].sort()
 }
 
+/**
+ * Compute missing required fields for a registry entry, using the merged
+ * runtimeConfig as source of truth so that env vars and runtimeConfig.public.scripts
+ * count toward satisfying the schema.
+ */
+export function findMissingRequiredFields(
+  requiredFields: string[],
+  rawInput: Record<string, any> | undefined,
+  mergedPublicScript: Record<string, any> | undefined,
+): string[] {
+  const { scriptOptions: _, ...effectiveInput } = mergedPublicScript ?? rawInput ?? {}
+  return requiredFields.filter(f => !effectiveInput[f])
+}
+
 export interface ModuleOptions {
   /**
    * Base path prefix for all script endpoints (proxy and bundled assets).
@@ -673,7 +687,10 @@ export default defineNuxtModule<ModuleOptions>({
         const willAutoLoad = scriptOptions && 'trigger' in scriptOptions && scriptOptions.trigger !== false
         if (willAutoLoad) {
           const requiredFields = extractRequiredFields(script.schema)
-          const missing = requiredFields.filter(f => !input[f])
+          // Check the merged runtimeConfig (input + env defaults + NUXT_PUBLIC_SCRIPTS_*),
+          // not just the raw registry input — required fields may be supplied via env.
+          const publicScripts = (nuxt.options.runtimeConfig.public?.scripts ?? {}) as Record<string, Record<string, any>>
+          const missing = findMissingRequiredFields(requiredFields, input, publicScripts[key])
           if (missing.length) {
             logger.warn(`[nuxt-scripts] registry.${key}: missing required field${missing.length > 1 ? 's' : ''} ${missing.map(f => `'${f}'`).join(', ')}. The script infrastructure is registered but will not function without ${missing.length > 1 ? 'them' : 'it'}.`)
           }

test/unit/setup.test.ts

@@ -1,6 +1,6 @@
 import type { NuxtConfigScriptRegistry } from '../../packages/script/src/runtime/types'
 import { describe, expect, it } from 'vitest'
-import { applyAutoInject, resolveConfiguredProxyDomains } from '../../packages/script/src/module'
+import { applyAutoInject, findMissingRequiredFields, resolveConfiguredProxyDomains } from '../../packages/script/src/module'
 
 describe('applyAutoInject', () => {
   const posthogAutoInject = {
@@ -149,3 +149,27 @@ describe('resolveConfiguredProxyDomains', () => {
     })).toEqual(['cdn.analytics.example.com', 'events.analytics.example.com'])
   })
 })
+
+describe('findMissingRequiredFields', () => {
+  it('flags fields missing from both raw input and merged runtimeConfig', () => {
+    expect(findMissingRequiredFields(['id'], {}, undefined)).toEqual(['id'])
+  })
+
+  it('treats fields satisfied via raw input as present', () => {
+    expect(findMissingRequiredFields(['id'], { id: 'G-123' }, undefined)).toEqual([])
+  })
+
+  it('treats fields supplied only via merged runtimeConfig.public.scripts as present', () => {
+    // Reproduces #761: id arrives via NUXT_PUBLIC_SCRIPTS_* / runtimeConfig and is
+    // merged into runtimeConfig.public.scripts before validation runs.
+    expect(findMissingRequiredFields(['id'], {}, { id: 'G-123' })).toEqual([])
+  })
+
+  it('ignores `scriptOptions` carried on the merged entry', () => {
+    expect(findMissingRequiredFields(['id'], {}, { scriptOptions: { bundle: true } })).toEqual(['id'])
+  })
+
+  it('returns only the still-missing subset', () => {
+    expect(findMissingRequiredFields(['id', 'apiKey'], {}, { id: 'G-123' })).toEqual(['apiKey'])
+  })
+})