fix(types): add typing for Routes meta #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for declaring the meta object in Nuxt.js Page, as we can see here https://github.com/nuxt/nuxt.js/tree/dev/examples/routes-meta 🤓 .
Contributor
|
@juliomrqz Thanks ! We're working on changing/fixing some implementation around the route In fact, this feature never has been documented, it only has been showcased around the example you linked. We agreed with other core team members to wait for these changes before providing types for this feature. Thanks in advance for your understanding 🙂 |
Contributor
Author
|
@kevinmarrec no problem, I understand |
kevinmarrec
added
the
types
Contributor
|
@juliomrqz Finally it sounds good to me so I'm merging it right now |
kevinmarrec
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for declaring the meta object in Nuxt.js Page, as we can see here https://github.com/nuxt/nuxt.js/tree/dev/examples/routes-meta 🤓 .