Skip to content

docs(ja): add en updates to Japanese document #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2019
Merged

docs(ja): add en updates to Japanese document #236

merged 4 commits into from
Dec 8, 2019

Conversation

aytdm
Copy link
Contributor

@aytdm aytdm commented Dec 8, 2019 •
edited
Loading

I added en document updates (#210, #233, #234, #235) to Japanese documents.

@aytdm aytdm marked this pull request as ready for review December 8, 2019 09:29
@kevinmarrec kevinmarrec added the documentation The issue or pull request related to the documentation label Dec 8, 2019
kevinmarrec
kevinmarrec approved these changes Dec 8, 2019
View reviewed changes
Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aytdm !

@kevinmarrec kevinmarrec merged commit 9e5417a into nuxt:master Dec 8, 2019
@aytdm aytdm deleted the take-en-docs-update-into-ja branch December 8, 2019 16:01
kevinmarrec pushed a commit that referenced this pull request Dec 9, 2019
@aytdm @kevinmarrec
docs(ja): add en updates to Japanese document (#236)
75febc5 
* docs(ja): fix package.json in runtime section from #210

* docs(ja): reorder yarn command to be before npm command (from #235)

* docs(ja): add warning for programmatic usage (from #233)

* docs(ja): add information on adding vue-shim.d.ts (from #234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kevinmarrec kevinmarrec kevinmarrec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aytdm aytdm

Labels

documentation The issue or pull request related to the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aytdm @kevinmarrec