Skip to content

Conversation

@hywax
Copy link
Member

@hywax hywax commented Oct 30, 2025

πŸ”— Linked issue

None

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Not accounting for the component’s model type.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hywax hywax requested a review from benjamincanac as a code owner October 30, 2025 08:40
@github-actions github-actions bot added the v4 #4488 label Oct 30, 2025
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

npm i https://pkg.pr.new/@nuxt/ui@5349

commit: b6c1c7b

Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments:

src/runtime/components/RadioGroup.vue (line 5):
Missing import for GetModelValueEmits type, which is now used in the RadioGroupEmits type definition but not imported.

View Details
πŸ“ Patch Details
diff --git a/src/runtime/components/RadioGroup.vue b/src/runtime/components/RadioGroup.vue
index eff0f161..00247334 100644
--- a/src/runtime/components/RadioGroup.vue
+++ b/src/runtime/components/RadioGroup.vue
@@ -2,7 +2,7 @@
 import type { RadioGroupRootProps, RadioGroupRootEmits } from 'reka-ui'
 import type { AppConfig } from '@nuxt/schema'
 import theme from '#build/ui/radio-group'
-import type { AcceptableValue, GetItemKeys, GetModelValue } from '../types/utils'
+import type { AcceptableValue, GetItemKeys, GetModelValue, GetModelValueEmits } from '../types/utils'
 import type { ComponentConfig } from '../types/tv'
 
 type RadioGroup = ComponentConfig<typeof theme, AppConfig, 'radioGroup'>

Analysis

Missing import for GetModelValueEmits type in RadioGroup.vue causes compilation error

What fails: RadioGroupEmits type definition in src/runtime/components/RadioGroup.vue line 76 uses GetModelValueEmits<T, VK, false> but this type is not imported

How to reproduce:

pnpm exec vue-tsc --noEmit --skipLibCheck

Result: TypeScript compilation fails with error TS2304: Cannot find name 'GetModelValueEmits' at src/runtime/components/RadioGroup.vue(76,5)

Expected: Component should compile successfully like other components (Select.vue, SelectMenu.vue, InputMenu.vue) that properly import GetModelValueEmits from '../types/utils'

@benjamincanac benjamincanac changed the title fix(RadioGroup): update type emit 'update:modelValue' fix(RadioGroup): update update:modelValue emit type Oct 31, 2025
@benjamincanac benjamincanac merged commit 4cb0638 into nuxt:v4 Oct 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants