-
Notifications
You must be signed in to change notification settings - Fork 921
fix(RadioGroup): update update:modelValue emit type
#5349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
commit: |
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments:
src/runtime/components/RadioGroup.vue (line 5):
Missing import for GetModelValueEmits type, which is now used in the RadioGroupEmits type definition but not imported.
View Details
π Patch Details
diff --git a/src/runtime/components/RadioGroup.vue b/src/runtime/components/RadioGroup.vue
index eff0f161..00247334 100644
--- a/src/runtime/components/RadioGroup.vue
+++ b/src/runtime/components/RadioGroup.vue
@@ -2,7 +2,7 @@
import type { RadioGroupRootProps, RadioGroupRootEmits } from 'reka-ui'
import type { AppConfig } from '@nuxt/schema'
import theme from '#build/ui/radio-group'
-import type { AcceptableValue, GetItemKeys, GetModelValue } from '../types/utils'
+import type { AcceptableValue, GetItemKeys, GetModelValue, GetModelValueEmits } from '../types/utils'
import type { ComponentConfig } from '../types/tv'
type RadioGroup = ComponentConfig<typeof theme, AppConfig, 'radioGroup'>
Analysis
Missing import for GetModelValueEmits type in RadioGroup.vue causes compilation error
What fails: RadioGroupEmits type definition in src/runtime/components/RadioGroup.vue line 76 uses GetModelValueEmits<T, VK, false> but this type is not imported
How to reproduce:
pnpm exec vue-tsc --noEmit --skipLibCheckResult: TypeScript compilation fails with error TS2304: Cannot find name 'GetModelValueEmits' at src/runtime/components/RadioGroup.vue(76,5)
Expected: Component should compile successfully like other components (Select.vue, SelectMenu.vue, InputMenu.vue) that properly import GetModelValueEmits from '../types/utils'
update:modelValue emit type
π Linked issue
None
β Type of change
π Description
Not accounting for the componentβs model type.
π Checklist