feat(FileUpload): add fileImage prop#5935
Conversation
📝 WalkthroughWalkthroughA new optional Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
previewFile prop
|
@mdotme Sorry for the delay, I've been hesitant merging this as I find the |
|
@benjamincanac yeah you're right that was the only thing came to my mind. Since currently it's previewing only the image maybe 'previewImage` is good? but I'm not sure |
|
What about |
|
Yeah that works for the current case. My thought was if you're planning to add other file previews would we have to add like |
|
I'm not sure how we could render a PDF or a video without adding heavy dependencies 😬 |
benjamincanac
left a comment
There was a problem hiding this comment.
We should rename previewFile to fileImage.
…e/nuxt-ui into feat/file-upload/preview-file
done! |
previewFile propfileImage prop
|
Thanks! 😊 |
🔗 Linked issue
Resolves #5918
❓ Type of change
📚 Description
📝 Checklist