fix(Select/SelectMenu/InputMenu): add fallback for max-height#6503
Conversation
The `max-h` on popper content relied on `--reka-*-content-available-height` which chains to `--reka-popper-available-height`. floating-ui sets that variable asynchronously, so on the initial render it's undefined — the `min()` expression becomes invalid and `max-height` drops to `none`. Without a bounded container the virtualizer renders every item at once. Add `15rem` as the `var()` fallback so the constraint holds before floating-ui positions the element, matching the original fixed `max-h-60`. Closes #6490
max-height
📝 WalkthroughWalkthroughThis PR adds CSS variable fallbacks to three theme files ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
max-heightmax-height
commit: |
🔗 Linked issue
Closes #6490
❓ Type of change
📚 Description
The
max-hon popper content relied on--reka-*-content-available-heightwhich chains to--reka-popper-available-height. floating-ui sets that variable asynchronously, so on the initial render it's undefined — themin()expression becomes invalid andmax-heightdrops tonone. Without a bounded container the virtualizer renders every item at once.Adds
15remas thevar()fallback so the constraint holds before floating-ui positions the element, matching the original fixedmax-h-60.📝 Checklist