Skip to content

fix(locale): improve Thai translation accuracy and consistency#6509

Merged
benjamincanac merged 2 commits into
nuxt:v4from
thanet-s:fix/thai-translation
May 27, 2026
Merged

fix(locale): improve Thai translation accuracy and consistency#6509
benjamincanac merged 2 commits into
nuxt:v4from
thanet-s:fix/thai-translation

Conversation

@thanet-s
Copy link
Copy Markdown
Contributor

🔗 Linked issue

No linked issue — this is a minor translation improvement PR.

❓ Type of change

  • 👌 Enhancement (improving an existing functionality)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)

📚 Description

This PR improves the Thai locale file with two focused changes:

1. Fixed pricingTable caption translation

Changed การเปรียบเทียบราคาสินค้า (product price comparison) to การเปรียบเทียบราคา (price comparison).

Why: The previous translation was too specific to physical goods (สินค้า = products/merchandise), while the PricingTable component is typically used for SaaS pricing tiers and plans. The new translation is more generic and works across all contexts — whether comparing software plans, services, or physical products. This better aligns with the English source text "Pricing plan comparison" which doesn't specify goods.

2. Reordered chatReasoning keys to match English source

Moved the chatReasoning block from between chatPromptSubmit and colorMode to between prose and sidebar, matching the key order in en.ts.

Why: Consistent key ordering across locale files makes it easier for contributors to compare translations against the English source. When keys are in the same order, maintainers can scroll both files side-by-side and quickly spot missing or mismatched entries without hunting for keys across the file.

📝 Checklist

  • I have read the contribution guidelines.
  • The changes are minimal and focused on translation quality.
  • No breaking changes introduced.

thanet-s added 2 commits May 27, 2026 11:41
Changed 'การเปรียบเทียบราคาสินค้า' (product price comparison) to 'การเปรียบเทียบราคา' (price comparison).

Reason: The previous translation was too specific to physical goods ('สินค้า' = products/merchandise), while the PricingTable component is typically used for SaaS pricing tiers/plans. The new translation is more generic and works across all contexts — whether comparing software plans, services, or physical products. This better aligns with the English source 'Pricing plan comparison' which doesn't specify goods.
…h source

Moved the chatReasoning block from between chatPromptSubmit and colorMode
to between prose and sidebar, matching the key order in en.ts.

Reason: Consistent key ordering across locale files makes it easier for
contributors to compare translations against the English source. When keys
are in the same order, maintainers can scroll both files side-by-side and
quickly spot missing or mismatched entries without hunting for keys.
@thanet-s thanet-s requested a review from benjamincanac as a code owner May 27, 2026 04:41
@github-actions github-actions Bot added the v4 #4488 label May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1246e6e0-44f1-4911-9a43-5631177db05e

📥 Commits

Reviewing files that changed from the base of the PR and between f4d7cbe and ed87395.

📒 Files selected for processing (1)
  • src/runtime/locale/th.ts

📝 Walkthrough

Walkthrough

This PR updates the Thai locale file with two changes: it reorganizes the chatReasoning message block by moving it from an earlier to a later position in the locale messages object, and it updates the pricingTable.caption Thai text from การเปรียบเทียบราคาสินค้า to การเปรียบเทียบราคา.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the two main changes: improving Thai translation accuracy and ensuring consistency with the English source file.
Description check ✅ Passed The description comprehensively explains both changes with clear rationale for why each modification improves the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/runtime/locale/th.ts

Parsing error: Unexpected token {


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 27, 2026

npm i https://pkg.pr.new/@nuxt/ui@6509

commit: ed87395

Copy link
Copy Markdown
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@benjamincanac benjamincanac merged commit 5d82418 into nuxt:v4 May 27, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants