Skip to content

fix(Slider): add aria-label to thumb #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 22, 2025
+41 −51
Merged

fix(Slider): add aria-label to thumb #5313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81f803d
fix(Slider): add aria-label to thumb
J-Michalek Oct 25, 2025
0fae890
Revert "fix(Slider): add aria-label to thumb"
J-Michalek Nov 22, 2025
c852b0d
up
J-Michalek Nov 22, 2025
d157bae
Merge branch 'v4' of github.com:J-Michalek/ui into fix/slider-a11y
J-Michalek Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/runtime/components/Slider.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ function onChange(value: any) {
disable-closing-trigger
v-bind="(typeof tooltip === 'object' ? tooltip : {})"
>
<SliderThumb data-slot="thumb" :class="ui.thumb({ class: props.ui?.thumb })" />
<SliderThumb data-slot="thumb" :class="ui.thumb({ class: props.ui?.thumb })" :aria-label="thumbs === 1 ? 'Thumb' : `Thumb ${thumb} of ${thumbs}`" />
</UTooltip>
<SliderThumb v-else data-slot="thumb" :class="ui.thumb({ class: props.ui?.thumb })" />
<SliderThumb v-else data-slot="thumb" :class="ui.thumb({ class: props.ui?.thumb })" :aria-label="thumbs === 1 ? 'Thumb' : `Thumb ${thumb} of ${thumbs}`" />
</template>
</SliderRoot>
</template>
12 changes: 1 addition & 11 deletions test/components/Slider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,7 @@ describe('Slider', () => {

}
})
expect(await axe(wrapper.element, {
rules: {
// "ARIA input fields must have an accessible name (aria-input-field-name)"

// Fix any of the following:
// aria-label attribute does not exist or is empty
// aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
// Element has no title attribute
'aria-input-field-name': { enabled: false }
}
})).toHaveNoViolations()
expect(await axe(wrapper.element)).toHaveNoViolations()
})

describe('emits', () => {
Expand Down
Loading
Loading