Skip to content

fix(ColorModeButton): use css to display color mode icon #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 17, 2025
Merged

fix(ColorModeButton): use css to display color mode icon #5394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1e5d5e
feat: remove clientonly
moshetanzer Nov 6, 2025
182d8e6
refactor(ColorModeButton): remove unused slot definition from ColorMo…
moshetanzer Nov 10, 2025
c1bc7b0
feat: add vue color mode with correct ui for icons
moshetanzer Nov 10, 2025
8923106
fix(ColorModeButton): update leading icon template to use ui class bi…
moshetanzer Nov 10, 2025
8aaddd2
fix(ColorModeButton): remove unused 'active' parameter from leading i…
moshetanzer Nov 10, 2025
31d6f96
Update src/runtime/vue/components/color-mode/ColorModeButton.vue
benjamincanac Nov 17, 2025
933a129
Merge branch 'v4' into feat/use-css-for-color-mode
benjamincanac Nov 17, 2025
f7610e0
fix: remove ColorModeButton override for vue
benjamincanac Nov 17, 2025
a5499e9
fix: use `leadingIcon`
benjamincanac Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions src/runtime/components/color-mode/ColorModeButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ const props = withDefaults(defineProps<ColorModeButtonProps>(), {
color: 'neutral',
variant: 'ghost'
})
defineSlots<{
fallback(props?: {}): any
}>()
const { t } = useLocale()
const colorMode = useColorMode()
Expand All @@ -48,21 +45,17 @@ const isDark = computed({
</script>

<template>
<ClientOnly v-if="!colorMode?.forced">
<UButton
v-bind="{
...buttonProps,
'icon': props.icon || (isDark ? appConfig.ui.icons.dark : appConfig.ui.icons.light),
'aria-label': isDark ? t('colorMode.switchToLight') : t('colorMode.switchToDark'),
...$attrs
}"
@click="isDark = !isDark"
/>

<template #fallback>
<slot name="fallback">
<div class="size-8" />
</slot>
<UButton
v-bind="{
...buttonProps,
'aria-label': isDark ? t('colorMode.switchToLight') : t('colorMode.switchToDark'),
...$attrs
}"
@click="isDark = !isDark"
>
<template #leading="{ ui }">
<UIcon :class="ui.leadingIcon({ class: props.ui?.leadingIcon })" class="hidden dark:inline" :name="appConfig.ui.icons.dark" />
<UIcon :class="ui.leadingIcon({ class: props.ui?.leadingIcon })" class="inline dark:hidden" :name="appConfig.ui.icons.light" />
</template>
</ClientOnly>
</UButton>
</template>
57 changes: 0 additions & 57 deletions src/runtime/vue/components/color-mode/ColorModeButton.vue
View file
Open in desktop

This file was deleted.

Loading