fix(Carousel): consistent stopOnInteraction behavior #5489
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
commit: |
J-Michalek
force-pushed
the
fix/carousel-consistent-interaction-stop
branch
from
f54461d to
af6073c
Compare
Contributor
Author
|
@benjamincanac I refactored this a little and also added handling for the autoscroll plugin which had the same behavior inconsistency as autoplay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #5488
❓ Type of change
📚 Description
There was inconsistency between swipe and click on arrow button while using the autoplay plugin - swipe used to stop the playing, but clicking the button did not. To me both seems like an interaction that should stop the playing.
📝 Checklist