Mini.completion with mini.snippets enabled throws error with svelte language server.

[231tr0n]

Contributing guidelines

• I have read CONTRIBUTING.md
• I have read CODE_OF_CONDUCT.md
• I have updated 'mini.nvim' to latest version of the main branch

Module(s)

mini.completion, mini.snippets

Neovim version

0.11.x

Description

I came across this error when using mini.completion and mini.snippets with svelte language server.

Reproduction

1. Make sure to have nodejs, npm and svelte-language-server installed. I use arch btw 😏 in WSL2, so with arch using yay yay -Syu --noconfirm svelte-language-server nodejs-lts npm does the job.
2. Below is the config to use to reproduce the issue.

-- Clone latest 'mini.nvim' (requires Git CLI installed)
vim.cmd('echo "Installing `mini.nvim`" | redraw')
local mini_path = vim.fn.stdpath("data") .. "/site/pack/deps/start/mini.nvim"
local clone_cmd = { "git", "clone", "--depth=1", "https://github.com/nvim-mini/mini.nvim", mini_path }
vim.fn.system(clone_cmd)
vim.cmd('echo "`mini.nvim` is installed" | redraw')

-- Make sure 'mini.nvim' is available
vim.cmd("packadd mini.nvim")
require("mini.deps").setup()
require("mini.snippets").setup()
require("mini.completion").setup()

MiniDeps.add("neovim/nvim-lspconfig")

local lsp_servers = {
	svelte = {
		settings = {
			typescript = {
				inlayHints = {
					parameterNames = { enabled = "all" },
					parameterTypes = { enabled = true },
					variableTypes = { enabled = true },
					propertyDeclarationTypes = { enabled = true },
					functionLikeReturnTypes = { enabled = true },
					enumMemberValues = { enabled = true },
				},
			},
		},
	},
}

vim.lsp.config("*", {
	capabilities = lsp_capabilities,
	root_markers = { ".git" },
})
for server, config in pairs(lsp_servers) do
	vim.lsp.config(server, config)
	vim.lsp.enable(server)
end

3. Clone this repo https://github.com/231tr0n/231tr0n.github.io.git.
4. Navigate into the git root directory.
5. Run npm install to install all packages. This step is necessary for the svelte language server to work, as it does not seem to work properly without installing all the packages.
6. Run NVIM_APPNAME=repro nvim -- src/routes/+layout.svelte.
7. Go to line number 5 and press o to create a new line 6.
8. Type import ass and press Ctrl-n to select the first element in the completion menu named asset and press Enter to get the error.

[echasnovski]

Thanks for the issue!

I am in the process of trying to reproduce this. What is the lsp_capabilities in vim.lsp.config? Also, did you try to actually reproduce the way you describe?

[231tr0n]

Thanks for the issue!

I am in the process of trying to reproduce this. What is the lsp_capabilities in vim.lsp.config? Also, did you try to actually reproduce the way you describe?

Yes, I tried to reproduce it the way I described exactly and I can confirm it is reproducible.

[231tr0n]

I did not set any lsp_capabilities. Like, the config is just the snippet I pasted in the reproduction steps. I removed all the unnecessary stuff to try to make it easier for you to debug. I think it will be nil in this case, most likely since I did not set any variable named lsp_capabilities.

[echasnovski]

Yes, I tried to reproduce it the way I described exactly and I can confirm it is reproducible.

Yeah, I did reproduce. Will take a look.

I did not set any lsp_capabilities. Like, the config is just the snippet I pasted in the reproduction steps. I removed all the unnecessary stuff to try to make it easier for you to debug. I think it will be nil in this case, most likely since I did not set any variable named lsp_capabilities.

That's what confused me, because the call doesn't seem to be needed then.

[echasnovski]

The investigation showed that this is an issue with svelte-language-server, the same as described in this comment. TL;DR: it changes item's textEdit during 'completionItem/resolve' request, although it is explicitly must not do that. In particular for the use case described in this issue:

• Before resolve:

  textEdit = {
    newText = "{ asset$1 } from '\\$app/paths';",
    range = {
      start = { line = 5, character = 8 },
      ["end"] = { line = 6, character = 0 },
    }
  }
  

• After resolve:

  textEdit = {
    newText = "{ asset$1 } from '\\$app/paths';",
    range = {
      start = { line = 5, character = 8 },
      ["end"] = { line = 5, character = 11 },
    }
  }
  

My suggestion would be to open an issue for LSP server in particular. But since it is the second time for 'mini.completion', I've made changes to accommodate this type of misbehaving server on the "best effort basis". Should now be resolved on latest main.

[231tr0n]

Echasnovski as you suggested, I raised an issue in the svelte language server's repro.

[231tr0n]

Hi @echasnovski! Sorry for the ping. So I just tried reproducing the issue to produce the lsp log file to the upstream issue and captured the logs by setting the log level to TRACE. But the thing is in the log file the textEdits for completionItem/resolve request did not change at all even though the issue was reproduced with the mini.nvim. So is this a neovim issue, or am I doing something wrong here?
I have attached the log file below.

lsp.log

The config I used is below

-- Clone latest 'mini.nvim' (requires Git CLI installed)
vim.cmd('echo "Installing `mini.nvim`" | redraw')
local mini_path = vim.fn.stdpath("data") .. "/site/pack/deps/start/mini.nvim"
local clone_cmd = { "git", "clone", "--depth=1", "https://github.com/nvim-mini/mini.nvim", mini_path }
vim.fn.system(clone_cmd)
vim.cmd('echo "`mini.nvim` is installed" | redraw')

-- Make sure 'mini.nvim' is available
vim.cmd("packadd mini.nvim")
require("mini.deps").setup()
require("mini.snippets").setup()
require("mini.completion").setup()

MiniDeps.add("neovim/nvim-lspconfig")

local lsp_servers = {
	svelte = {
		settings = {
			typescript = {
				inlayHints = {
					parameterNames = { enabled = "all" },
					parameterTypes = { enabled = true },
					variableTypes = { enabled = true },
					propertyDeclarationTypes = { enabled = true },
					functionLikeReturnTypes = { enabled = true },
					enumMemberValues = { enabled = true },
				},
			},
		},
	},
}

vim.lsp.config("*", {
	capabilities = lsp_capabilities,
	root_markers = { ".git" },
})
vim.lsp.set_log_level("TRACE")
for server, config in pairs(lsp_servers) do
	vim.lsp.config(server, config)
	vim.lsp.enable(server)
end

After reproducing the issue as it is, I copied the log file from ~/.local/state/repro/lsp.log and submitted it.

[echasnovski]

So I just tried reproducing the issue to produce the lsp log file to the upstream issue and captured the logs by setting the log level to TRACE. But the thing is in the log file the textEdits for completionItem/resolve request did not change at all even though the issue was reproduced with the mini.nvim. So is this a neovim issue, or am I doing something wrong here?

Hmm... As this has occurred with different LSP servers and one of them checked their source code without luck, I do indeed wonder if this is somehow an issue with 'mini.completion' or Neovim itself. I'll take another look.