fix(view): do not close window when NvimTree buffer is replaced #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `actions.open_file` enabled, when an NvimTree buffer is changed to
some other buffer, the window in which that buffer swap occurs is
closed.
Since the `quit_on_open` function runs on `NvimTree` `BufWipeout`, there
should not be a need to close the window that holds that buffer.
This issue could be reproduced by:
1. Opening an existing file `:e firstfile.txt`
2. `:sp`
3. `:lua require("nvim-tree").open_replacing_current_buffer()`
4. Replacing the NvimTree buffer with some other buffer by
`:e somefile.txt`
The window containing the buffer opened in the first step would be
closed. There would be only a single window with `somefile.txt` on that
tab page.
With this commit, that window is retained and the tab now contains
`firstfile.txt` in the left window and `somefile.txt` in the right
window.
alex-courtis
approved these changes
Jul 3, 2022
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
This tests OK. The change is limited in scope to quit_on_open so there are limited chances of side-effects.
Matches documented behaviour:
nvim-tree.actions.open_file.quit_on_open
Closes the explorer when opening a file.
It will also disable preventing a buffer overriding the tree.
Type: boolean, Default: false
Contributor
Author
|
Thanks for testing and merging this PR! I appreciate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
actions.open_fileenabled, when an NvimTree buffer is changed to some other buffer, the window in which that buffer swap occurs is closed.Since the
quit_on_openfunction runs onNvimTreeBufWipeout, there should not be a need to close the window that holds that buffer. Looking at the code, it seemed sensible to not to call_prevent_buffer_overrideifquit_on_openis enabled, since at best it's a no-op, and at worst it will accidentally modify the window layout.This issue could be reproduced by:
:e firstfile.txt:vs:lua require("nvim-tree").open_replacing_current_buffer():e somefile.txtThe window containing the buffer opened in the first step would be closed. There would be only a single window with
somefile.txton that tab page.Peek.2022-07-03.12-44-failed.mp4
With this fix, that window is retained and the tab now contains
firstfile.txtin the left window andsomefile.txtin the rightwindow.
Peek.2022-07-03.12-44.mp4