feat(renderer): add NvimTreeSymlinkFolderName #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
requested changes
Feb 18, 2023
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
This works and will be useful, thanks for your contribution.
Please:
- remove defaults, linking to
FolderName
qtyosaf
force-pushed
the
folder-symlink-colors
branch
from
f4466f9 to
68676cf
Compare
Contributor
Author
|
Sorry for taking so long to update the pull request! I changed things according to the comments. Changes: |
alex-courtis
approved these changes
Apr 6, 2023
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Tested:
- default to Directory
- default to NvimTreeFolderName
- uses NvimTreeSymlinkFolderName
alex-courtis
requested changes
Apr 6, 2023
alex-courtis
changed the title
alex-courtis
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Color named
FolderSymlinkadded incolors.lua.Color applied to folder symlinks in
_build_folderfunction inbuilder.luaAdded color to Highlight Groups in documentation.
I believe this change is necessary to add more contrast for folder symlinks.