fix(#2507): icon in message after rename-file #2510
Conversation
|
FYI: you don't need to open a new PR when you want to change something, you can just add another commit to the branch. |
|
ok thank you. should i close PR and commit again? |
|
No, if some changes are needed just push a new commit to your |
| if not ALLOWED_MODIFIERS[modifier] then | ||
| return notify.warn("Modifier " .. vim.inspect(modifier) .. " is not in allowed list : " .. table.concat(ALLOWED_MODIFIERS, ",")) | ||
| return notify.warn( | ||
| string.format("Modifier %s is not in allowed list: %s", vim.inspect(modifier), table.concat(ALLOWED_MODIFIERS, ",")) |
There was a problem hiding this comment.
I am sorry. I understood gegoune's words to fix that as well.
There was a problem hiding this comment.
Well, now that I think about it, I'm not sure if the "same here" is about the unrelated style changes or the use of string.format... Let's wait for his feedback.
There was a problem hiding this comment.
Okay and I finally understand your FYI. Thank you for your kindness.
There was a problem hiding this comment.
Apologies if I wasn't clear enough. My fault.
Regarding unrelated changes: I meant it for formatting changes toward the top of file.
string.format is what we should be using going forward but as @Akmadan23 said existing code should not be changed as part of that pr to make it self contained. We can replace other string concatenations across code base in separate pr (I can do it).
Hope that clears things up. Thanks for your pr!
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Many thanks for your contribution!
Compatibility with all terminals is desirable.
4 participants
Closes #2507