-
-
Notifications
You must be signed in to change notification settings - Fork 633
feat: add api.marks.bulk.trash #2391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution. We do need some work:
- remove unnecessary refresh
- handle
ui.confirm.trash = false
Testing:
OK:
mark and trash files and folders - y
mark and trash - n
mark and trash - rubbish trash.cmd
nothing marked
filesystem_watchers.enable = false
Event.WillRemoveFile
Event.FileRemoved
Event.FolderRemoved
Fail:
ui.confirm.trash = false
- doesn't prompt
Many thanks for this one; trash is a useful feature. |
Screen.Recording.2023-09-14.at.8.10.03.pm.movDo you want me to handle any test cases related to |
It is indeed working as expected. I cannot recall my thought process there. Please accept my apologies. Re-tested a subset - it's all looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works beautifully, many thanks for your contribution!
No worries mate, all good 🙂 |
API to trash bulk files using external trash cli or similar
Tested with
OS: MacOS Ventura
CLI:
put back
options on OS X sindresorhus/trash#24, so I recommend using above CLIKeybinding:
Add below keybinding to trash bulk files